Bug 1241922 - Review Request: perl-Test-LWP-UserAgent - LWP::UserAgent suitable for simulating and testing network calls
Summary: Review Request: perl-Test-LWP-UserAgent - LWP::UserAgent suitable for simulat...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-07-10 12:21 UTC by Jitka Plesnikova
Modified: 2015-08-11 17:03 UTC (History)
2 users (show)

Fixed In Version: perl-Test-LWP-UserAgent-0.029-1.fc23
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-08-11 17:03:47 UTC
Type: ---
Embargoed:
psabata: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Jitka Plesnikova 2015-07-10 12:21:01 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-Test-LWP-UserAgent/perl-Test-LWP-UserAgent.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Test-LWP-UserAgent/perl-Test-LWP-UserAgent-0.029-1.fc23.src.rpm
Description:
This module is a subclass of LWP::UserAgent which overrides a few key low-
level methods that are concerned with actually sending your request over
the network, allowing an interception of that request and simulating a
particular response. This greatly facilitates testing of client networking
code where the server follows a known protocol.

Fedora Account System Username: jplesnik

Comment 1 Petr Šabata 2015-07-14 09:31:36 UTC
Missing a buildtime dependency:
 - warnings, used all over the place

Add a version constraint for ExtUtils::MakeMaker.  NO_PACKLIST requires v6.76+.

It's not strictly required at the moment (given how the testsuite is written) but I think it'd be a good idea to enable NO_NETWORK_TESTING anyway.  It may prevent future breakage.

You don't have to filter the MyApp::Client provides.  The documentation isn't scanned.

Comment 2 Jitka Plesnikova 2015-07-14 11:15:52 UTC
Updated files are on the same links. 

I can't remove filter of provides, because it seems the documentation is scanned.

Comment 3 Petr Šabata 2015-07-14 11:27:28 UTC
(In reply to Jitka Plesnikova from comment #2)
> Updated files are on the same links. 

Ack.

> I can't remove filter of provides, because it seems the documentation is
> scanned.

Indeed, that was my mistake.

Approving.

Comment 4 Jitka Plesnikova 2015-07-14 11:46:25 UTC
New Package SCM Request
=======================
Package Name: perl-Test-LWP-UserAgent
Short Description: LWP::UserAgent suitable for simulating and testing network calls
Upstream URL: http://search.cpan.org/dist/Test-LWP-UserAgent/
Owners: jplesnik ppisar psabata
Branches:
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2015-07-15 17:40:25 UTC
Git done (by process-git-requests).

Comment 6 Jitka Plesnikova 2015-07-16 06:24:19 UTC
Package Change Request
======================
Package Name: perl-Test-LWP-UserAgent
New Branches: f23
Owners: jplesnik ppisar psabata
InitialCC: perl-sig

Comment 7 Jitka Plesnikova 2015-07-16 13:04:32 UTC
Thank you for the review and the repository.

Comment 8 Kevin Fenzi 2015-07-20 17:20:46 UTC
Git done (by process-git-requests).

Comment 9 Petr Šabata 2015-08-11 17:03:47 UTC
I suppose this can be closed now.


Note You need to log in before you can comment on or make changes to this bug.