Spec URL: http://people.parinux.org/~seyman/fedora/perl-Hash-Layout/perl-Hash-Layout.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Hash-Layout/perl-Hash-Layout-1.02-1.fc22.src.rpm Description: Hash::Layout provides deep hashes with a predefined number of levels which you can access using special "composite keys". These are essentially string paths that inflate into actual hash keys according to the defined levels and delimiter mappings, which can be the same or different for each level. This is useful both for shorter keys as well as merge/fallback to default values, such as when defining overlapping configs ranging from broad to narrowing scope. Fedora Account System Username: eseyman Rpmlint Output: perl-Hash-Layout.src: W: spelling-error %description -l en_US configs -> con figs, con-figs, configure 1 packages and 1 specfiles checked; 0 errors, 1 warnings.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: t/99_pod.t .............. skipped: Test::Pod 1.14 required t/99_podcoverage.t ...... skipped: Test::Pod::Coverage 1.04 required Looks like you should BR perl(Test::Pod) and perl(Test::Pod::Coverage) ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /export/home/orion/redhat/1242663-perl-Hash- Layout/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/Hash(perl-Hash-Case, perl-Hash-Flatten, perl-Hash-MoreUtils, perl-Hash-Merge, perl-Hash-WithDefaults, perl- Hash-MultiValue, perl-Hash-Merge-Simple, perl-Hash-Util-FieldHash- Compat) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: perl-Hash-Layout-1.02-1.fc22.noarch.rpm perl-Hash-Layout-1.02-1.fc22.src.rpm perl-Hash-Layout.noarch: W: spelling-error %description -l en_US configs -> con figs, con-figs, configure perl-Hash-Layout.src: W: spelling-error %description -l en_US configs -> con figs, con-figs, configure 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- perl-Hash-Layout.noarch: W: spelling-error %description -l en_US configs -> con figs, con-figs, configure 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- perl-Hash-Layout (rpmlib, GLIBC filtered): perl(:MODULE_COMPAT_5.20.2) perl(Clone) perl(Hash::Layout::Level) perl(Hash::Merge::Simple) perl(Moo) perl(Scalar::Util) perl(Types::Standard) perl(strict) perl(warnings) Provides -------- perl-Hash-Layout: perl(Hash::Layout) perl(Hash::Layout::Level) perl-Hash-Layout Source checksums ---------------- http://www.cpan.org/authors/id/V/VA/VANSTYN/Hash-Layout-1.02.tar.gz : CHECKSUM(SHA256) this package : 9cae06a2680f455dba3bbd0f62311532146c50bb08ff3676e85f044fd05729fc CHECKSUM(SHA256) upstream package : 9cae06a2680f455dba3bbd0f62311532146c50bb08ff3676e85f044fd05729fc Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/bin/fedora-review -b 1242663 Buildroot used: fedora-22-x86_64 Active plugins: Generic, Shell-api, Perl Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(In reply to Orion Poplawski from comment #1) > > Issues: > t/99_pod.t .............. skipped: Test::Pod 1.14 required > t/99_podcoverage.t ...... skipped: Test::Pod::Coverage 1.04 required > > Looks like you should BR perl(Test::Pod) and perl(Test::Pod::Coverage) Indeed. Not sure how I missed that. Spec URL: http://people.parinux.org/~seyman/fedora/perl-Hash-Layout/perl-Hash-Layout.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Hash-Layout/perl-Hash-Layout-1.02-2.fc22.src.rpm When built in mock, this version of the package runs all the tests.
Great. However, instead of "Take into account review comments" I would have said what was done, e.g. "Added BR perl(Test::Pod) and perl(Test::Pod::Coverage)". Always good to be explicit. APPROVED.
Thanks for the review. Requesting SCM. New Package SCM Request ======================= Package Name: perl-Hash-Layout Short Description: Hashes with predefined levels, composite keys and default values Upstream URL: http://search.cpan.org/dist/Hash-Layout/ Owners: eseyman Branches: f22 f23 InitialCC: perl-sig
Git done (by process-git-requests).
perl-Hash-Layout-1.02-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/perl-Hash-Layout-1.02-2.fc22
perl-Hash-Layout-1.02-2.fc22 has been pushed to the Fedora 22 testing repository.
perl-Hash-Layout-1.02-2.fc22 has been pushed to the Fedora 22 stable repository.