Bug 1245356 - Review Request: python-ansi - ANSI cursor movement and graphics
Summary: Review Request: python-ansi - ANSI cursor movement and graphics
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-07-21 20:53 UTC by Sebastian Dyroff
Modified: 2015-08-07 13:09 UTC (History)
2 users (show)

Fixed In Version: python-ansi-0.1.3-3.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-08-07 13:09:35 UTC
Type: ---
Embargoed:
i: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Sebastian Dyroff 2015-07-21 20:53:51 UTC
Spec URL: http://www.dyroff.net/fedora/python-ansi.spec
SRPM URL: http://www.dyroff.net/fedora/python-ansi-0.1.3-1.fc22.src.rpm
Description: Various ANSI escape codes, used in moving the cursor in a text console or rendering colored text with Python
Fedora Account System Username: sdyroff

Comment 1 Christopher Meng 2015-07-22 00:42:16 UTC
Better source url:

https://pypi.python.org/packages/source/a/ansi/ansi-0.1.3.tar.gz

to avoid dumb folder name like ansi-ansi and github source guideline ...

Comment 2 Sebastian Dyroff 2015-07-22 08:00:04 UTC
Thanks, fixed. See

Spec URL: http://www.dyroff.net/fedora/python-ansi.spec
SRPM URL: http://www.dyroff.net/fedora/python-ansi-0.1.3-2.fc22.src.rpm

Comment 3 Christopher Meng 2015-07-25 17:30:33 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 4 files have unknown license. Detailed
     output of licensecheck:

Unknown or generated
--------------------
python-ansi-0.1.3/ansi/_compat.py
python-ansi-0.1.3/ansi/colour/__init__.py

[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[-]: Package consistently uses macros (instead of hard-coded directory
     names).
[-]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-ansi
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.


Rpmlint
-------
Checking: python-ansi-0.1.3-2.fc22.noarch.rpm
          python3-ansi-0.1.3-2.fc22.noarch.rpm
          python-ansi-0.1.3-2.fc22.src.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
2 packages and 0 specfiles checked; 0 errors, 0 warnings.



Requires
--------
python-ansi (rpmlib, GLIBC filtered):
    python(abi)

python3-ansi (rpmlib, GLIBC filtered):
    python(abi)



Provides
--------
python-ansi:
    python-ansi

python3-ansi:
    python3-ansi



Source checksums
----------------
https://pypi.python.org/packages/source/a/ansi/ansi-0.1.3.tar.gz :
  CHECKSUM(SHA256) this package     : ef1eff1d52ee5db71e0954e515c32ec0a65933326c8bf887f698eebfc021c61b
  CHECKSUM(SHA256) upstream package : ef1eff1d52ee5db71e0954e515c32ec0a65933326c8bf887f698eebfc021c61b


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -rvn python-ansi-0.1.3-2.fc22.src.rpm
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

------------------------------------------------
This package is APPROVED with issues below, fix them BEFORE SCM.

1. Source0:        https://pypi.python.org/packages/source/a/ansi/ansi-0.1.3.tar.gz

Not issue, but suggestion to use this:

Source0:        https://pypi.python.org/packages/source/a/ansi/ansi-%{version}.tar.gz

----------

2. %build
pushd python2
FLAGS="$RPM_OPT_FLAGS" %{__python2} setup.py build
popd
%if 0%{?with_python3}
pushd python3
CFLAGS="$RPM_OPT_FLAGS" %{__python3} setup.py build
popd
%endif # with_python3

This package doesn't use Cython. Please drop FLAGS="$RPM_OPT_FLAGS".

3. Leave a blank line for each changelog entry.

Comment 4 Sebastian Dyroff 2015-07-27 12:34:30 UTC
New Package SCM Request
=======================
Package Name: python-ansi
Short Description: ANSI cursor movement and graphics
Upstream URL: https://github.com/tehmaze/ansi
Owners: sdyroff
Branches: f22 f23
InitialCC: sdyroff

Comment 5 Gwyn Ciesla 2015-07-27 19:19:42 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2015-07-28 12:16:46 UTC
python-ansi-0.1.3-3.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/python-ansi-0.1.3-3.fc22

Comment 7 Fedora Update System 2015-07-30 00:53:33 UTC
python-ansi-0.1.3-3.fc22 has been pushed to the Fedora 22 testing repository.

Comment 8 Fedora Update System 2015-08-07 13:09:35 UTC
python-ansi-0.1.3-3.fc22 has been pushed to the Fedora 22 stable repository.


Note You need to log in before you can comment on or make changes to this bug.