Spec URL: https://drive.google.com/open?id=0B0D-SO5kT7MTbFNIbUR4UEpzTzA SRPM URL: https://drive.google.com/open?id=0B0D-SO5kT7MTVXhTTllIYzRKWnc Description: scandir() is a directory iteration function like os.listdir(), except that instead of returning a list of bare filenames, it yields DirEntry objects that include file type and stat information along with the name. Using scandir() increases the speed of os.walk() by 2-20 times (depending on the platform and file system) by avoiding unnecessary calls to os.stat() in most cases. scandir is included in the Python 3.5+ standard library. https://github.com/benhoyt/scandir This package makes scandir available for Python 2 and Python <3.5 Fedora Account System Username: aviso Scratch builds: F24: https://koji.fedoraproject.org/koji/taskinfo?taskID=10443289 EL6: https://koji.fedoraproject.org/koji/taskinfo?taskID=10443284 EL7: https://koji.fedoraproject.org/koji/taskinfo?taskID=10443277 This is my first package, so I need a sponsor. The wiki says this is where I should post links to show I'm involved. Backported python-pgpdump to el6: bug 1030710 Help with python-pgpdump build failures: bug 1239850 Patches for python-defusedxml: bug 927883 Backported dhcp fix to el6: bug 1067142
Hi Aviso, Welcome! I'll take this review, will sponsor you once the review is complete.
Package looks good overall; there are a few minor changes (see review below especially the items marked with [!] Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions => false positive, when building in mock *.so get 0775 instead of 0755 permission. This would be fine on the build servers - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 => You don't need to BuildRequires: gcc, this is part of the list of packages always available in mock / koji. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 8 files have unknown license. Detailed output of licensecheck in /home/michel/sources/fedora/reviews/review- python-scandir/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/python3.4/site- packages/__pycache__(python3-libs) => exclude by adding %exclude %dir %{python3_sitearch}/__pycache__ above %{python3_sitearch}/* [!]: %build honors applicable compiler flags or justifies otherwise. You should use CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build instead of just %{__python} setup.py build Likewise with the Python 3 variant [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. No need to say python(abi) < 3.5 -- it's automatically set to be python(abi) == 3.4 Check with rpm -qp --requires python-scandir-1.1-1.*.rpm [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 122880 bytes in 14 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-scandir-1.1-1.fc22.x86_64.rpm python3-scandir-1.1-1.fc22.x86_64.rpm python-scandir-1.1-1.fc22.src.rpm python-scandir.x86_64: W: spelling-error Summary(en_US) os -> OS, och, so python-scandir.x86_64: W: spelling-error %description -l en_US os -> OS, och, so python-scandir.x86_64: W: spelling-error %description -l en_US listdir -> Lister python-scandir.x86_64: W: spelling-error %description -l en_US filenames -> file names, file-names, filaments python-scandir.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/_scandir.so 775 python3-scandir.x86_64: W: spelling-error Summary(en_US) os -> OS, och, so python3-scandir.x86_64: W: spelling-error %description -l en_US os -> OS, och, so python3-scandir.x86_64: W: spelling-error %description -l en_US listdir -> Lister python3-scandir.x86_64: W: spelling-error %description -l en_US filenames -> file names, file-names, filaments python3-scandir.x86_64: E: non-standard-executable-perm /usr/lib64/python3.4/site-packages/_scandir.cpython-34m.so 775 python-scandir.src: W: spelling-error Summary(en_US) os -> OS, och, so python-scandir.src: W: spelling-error %description -l en_US os -> OS, och, so python-scandir.src: W: spelling-error %description -l en_US listdir -> Lister python-scandir.src: W: spelling-error %description -l en_US filenames -> file names, file-names, filaments 3 packages and 0 specfiles checked; 2 errors, 12 warnings. Rpmlint (debuginfo) ------------------- Checking: python-scandir-debuginfo-1.1-1.fc22.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- python-scandir.x86_64: W: spelling-error Summary(en_US) os -> OS, och, so python-scandir.x86_64: W: spelling-error %description -l en_US os -> OS, och, so python-scandir.x86_64: W: spelling-error %description -l en_US listdir -> Lister python-scandir.x86_64: W: spelling-error %description -l en_US filenames -> file names, file-names, filaments python-scandir.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/_scandir.so 775 python3-scandir.x86_64: W: spelling-error Summary(en_US) os -> OS, och, so python3-scandir.x86_64: W: spelling-error %description -l en_US os -> OS, och, so python3-scandir.x86_64: W: spelling-error %description -l en_US listdir -> Lister python3-scandir.x86_64: W: spelling-error %description -l en_US filenames -> file names, file-names, filaments python3-scandir.x86_64: E: non-standard-executable-perm /usr/lib64/python3.4/site-packages/_scandir.cpython-34m.so 775 3 packages and 0 specfiles checked; 2 errors, 8 warnings. Requires -------- python-scandir (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) python(abi) rtld(GNU_HASH) python3-scandir (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpthread.so.0()(64bit) libpython3.4m.so.1.0()(64bit) python(abi) rtld(GNU_HASH) Provides -------- python-scandir: python-scandir python-scandir(x86-64) python3-scandir: python3-scandir python3-scandir(x86-64) Unversioned so-files -------------------- python-scandir: /usr/lib64/python2.7/site-packages/_scandir.so python3-scandir: /usr/lib64/python3.4/site-packages/_scandir.cpython-34m.so Source checksums ---------------- https://github.com/benhoyt/scandir/archive/v1.1.tar.gz#/scandir-1.1.tar.gz : CHECKSUM(SHA256) this package : 3e493e62409a47f804c00853e00e46ab4ba9b32deaaf295ab9231d7474f49d93 CHECKSUM(SHA256) upstream package : 3e493e62409a47f804c00853e00e46ab4ba9b32deaaf295ab9231d7474f49d93 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -n python-scandir Buildroot used: fedora-22-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Thanks for reviewing the package, Michel I made the changes you suggested and updated the spec and srpm files at their original locations. For reference, below is a quick diff of the spec files. diff python-scandir.spec.orig python-scandir.spec 16d15 < BuildRequires: gcc 33d31 < Requires: python(abi) < 3.5 52c50 < %{__python} setup.py build --- > CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build 55c53 < %{__python3} setup.py build --- > CFLAGS="$RPM_OPT_FLAGS" %{__python3} setup.py build 90a89 > %exclude %dir %{python3_sitearch}/__pycache__
Taking a final look now. ps it's preferable to use unified diff, because that shows the context in which the change is made e.g. diff -u python-scandir{-orig,}.spec --- python-scandir-orig.spec 2015-07-24 23:51:39.183792897 +0700 +++ python-scandir.spec 2015-07-26 10:11:31.913915790 +0700 @@ -13,7 +13,6 @@ License: BSD BuildRequires: python2-devel -BuildRequires: gcc %if 0%{?with_python3} BuildRequires: python3-devel @@ -30,7 +29,6 @@ %if 0%{?with_python3} %package -n python3-%{pkgname} Summary: A better directory iterator and faster os.walk() for Python -Requires: python(abi) < 3.5 %description -n python3-%{pkgname} scandir() is a directory iteration function like os.listdir(), except that @@ -49,10 +47,10 @@ %endif %build -%{__python} setup.py build +CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build %if 0%{?with_python3} pushd %{py3dir} -%{__python3} setup.py build +CFLAGS="$RPM_OPT_FLAGS" %{__python3} setup.py build popd %endif @@ -88,6 +86,7 @@ %{!?_licensedir:%global license %%doc} %license LICENSE* %doc README* test benchmark.py +%exclude %dir %{python3_sitearch}/__pycache__ %{python3_sitearch}/* %endif
Changes look good; this review is APPROVED Have you introduced yourself on fedora-devel? I couldn't find your email there https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Introduce_yourself (will add you to the packager group once that's done)
Thanks, Michel. Just sent it. Also switched display name from Aviso to Avram Lubkin so it matches my email.
New Package SCM Request ======================= Package Name: python-scandir Short Description: A better directory iterator and faster os.walk() for Python Upstream URL: https://github.com/benhoyt/scandir Owners: aviso salimma Branches: f21 f22 f23 el6 epel7
Hi Avram, FYI no need to make me a package owner, just putting me on the InitialCc would do, thanks
Git done (by process-git-requests).
python-scandir-1.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-scandir-1.1-1.el6
python-scandir-1.1-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-scandir-1.1-1.el7
python-scandir-1.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-scandir-1.1-1.fc21
python-scandir-1.1-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-scandir-1.1-1.fc22
python-scandir-1.1-1.fc22 has been pushed to the Fedora 22 testing repository.
python-scandir-1.1-1.fc22 has been pushed to the Fedora 22 stable repository.
python-scandir-1.1-1.fc21 has been pushed to the Fedora 21 stable repository.
python-scandir-1.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
python-scandir-1.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
Please don't block on FE-NEEDSPONSOR for a finished review/bug.