Description of problem: When use invalid token to clone repo from origin-gitserver, it always tip http 500 error, the tip info is confusing. Version-Release number of selected component (if applicable): openshift v1.0.4-184-gc5f08bc-dirty kubernetes v1.1.0-alpha.0-1155-gb73c53c How reproducible: Always Steps to Reproduce: 1.Config gitserver to use token to auth $ cat examples/gitserver/gitserver.yaml ---skip--- - name: REQUIRE_SERVER_AUTH value: "-" 2.Deploy a private gitserver $ oc create -f gitserver.yaml -n dma1 3.Input invalid token(password) to clone the repo from origin-gitserver [fedora@ip-10-154-3-36 ruby-sample-build]$ git clone http://172.30.215.113:8080/test.git Cloning into 'test'... Username for 'http://172.30.215.113:8080': dma Password for 'http://dma@172.30.215.113:8080': remote: the server has asked for the client to provide credentials (post subjectAccessReviews) fatal: unable to access 'http://172.30.215.113:8080/test.git/': The requested URL returned error: 500 Actual results: 3. The tip info is error 500, it's confusing Expected results: 3. It should tip Forbidden or the token is invalid. Additional info:
Hrm - the default token should let us perform SARs.
On ose env, always fail with 500 error, even use correct token. [root@openshift-106 gitserver]# git clone http://172.30.224.220:8080/test.git Cloning into 'test'... Username for 'http://172.30.224.220:8080': dma Password for 'http://dma@172.30.224.220:8080': fatal: unable to access 'http://172.30.224.220:8080/test.git/': The requested URL returned error: 500
PR https://github.com/openshift/origin/pull/5894
[fedora@ip-172-18-9-199 sample-app]$ openshift version openshift v1.1-60-g0411059 kubernetes v1.1.0-origin-1107-g4c8e6f4 etcd 2.1.2 [fedora@ip-172-18-9-199 sample-app]$ git clone http://172.30.91.206:8080/test.git Cloning into 'test'... Username for 'http://172.30.91.206:8080': dma Password for 'http://dma@172.30.91.206:8080': remote: the server has asked for the client to provide credentials (post localSubjectAccessReviews) fatal: Authentication failed for 'http://172.30.91.206:8080/test.git/'