Bug 1256048 - Commit a previewed snapshot with Cinder disk should remove all its "children" snapshots
Summary: Commit a previewed snapshot with Cinder disk should remove all its "children"...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: General
Version: 3.6.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-3.6.2
: 3.6.2
Assignee: Maor
QA Contact: Natalie Gavrielov
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-08-23 16:28 UTC by Maor
Modified: 2016-03-10 15:16 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-02-23 13:32:10 UTC
oVirt Team: Storage
Embargoed:
ylavi: ovirt-3.6.z?
ylavi: planning_ack+
tnisan: devel_ack+
ylavi: testing_ack?

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1256049 0 medium CLOSED [Cinder] Commit a previewed snapshot with Cinder disk should remove orphaned disks 2021-02-22 00:41:40 UTC
oVirt gerrit 43814 0 master ABANDONED core: Add stored procedure for descendant snapshot Never
oVirt gerrit 43815 0 master ABANDONED core: [WIP] Remove descendant snapshots when committing a previewd snapshot. Never
oVirt gerrit 48937 0 master MERGED core: Add Cinder helper method for candidate volumes to delete. Never
oVirt gerrit 48938 0 master MERGED core: Add updateSnapshot to CinderDiskParameters. Never
oVirt gerrit 48939 0 master MERGED core: Use linked list instead of list. Never
oVirt gerrit 48940 0 master MERGED core: Add a new Cinder volume parent command. Never
oVirt gerrit 48941 0 master MERGED core: Restore snapshot should handle Cinder snapshot. Never
oVirt gerrit 48942 0 master MERGED core: Refactor, Use RemoveCinderVolumeParentCommand method. Never
oVirt gerrit 48943 0 master ABANDONED core: Refactor, use getDisk at RemoveCinderDiskCommand. Never
oVirt gerrit 49413 0 master MERGED core: Get initial Cinder volume to restore from. Never
oVirt gerrit 49414 0 master MERGED core: Get previewed snapshot's images by the snapshot's OVF. Never
oVirt gerrit 49416 0 master ABANDONED core: Remove redundant Cinder snapshots after commit. Never
oVirt gerrit 49417 0 master MERGED core: Rename parameter cinderDisks to cinderDisksToRestore. Never
oVirt gerrit 49418 0 master MERGED core: before unlock a VM, fetch it from the DB Never
oVirt gerrit 49419 0 master MERGED core: RestoreCinderSnapshot should delete volumes by order. Never
oVirt gerrit 49420 0 master MERGED core: Re-factor restore snapshot for Cinder disks. Never
oVirt gerrit 49428 0 master MERGED core: Add cinder volume type for VM's disks' OVF. Never
oVirt gerrit 49685 0 master MERGED core: cleanup, use getDiskImageDao at isCinderHasNoImages. Never
oVirt gerrit 50054 0 ovirt-engine-3.6 MERGED core: Add Cinder helper method for candidate volumes to delete. Never
oVirt gerrit 50055 0 ovirt-engine-3.6 MERGED core: cleanup, use getDiskImageDao at isCinderHasNoImages. Never
oVirt gerrit 50056 0 ovirt-engine-3.6 MERGED core: Add updateSnapshot to CinderDiskParameters. Never
oVirt gerrit 50057 0 ovirt-engine-3.6 MERGED core: Use linked list instead of list. Never
oVirt gerrit 50058 0 ovirt-engine-3.6 MERGED core: Add a new Cinder volume parent command. Never
oVirt gerrit 50059 0 ovirt-engine-3.6 MERGED core: Restore snapshot should handle Cinder snapshot. Never
oVirt gerrit 50060 0 ovirt-engine-3.6 MERGED core: Refactor, Use RemoveCinderVolumeParentCommand method. Never
oVirt gerrit 50061 0 ovirt-engine-3.6 MERGED core: Get initial Cinder volume to restore from. Never
oVirt gerrit 50062 0 ovirt-engine-3.6 MERGED core: Add cinder volume type for VM's disks' OVF. Never
oVirt gerrit 50063 0 ovirt-engine-3.6 MERGED core: Get previewed snapshot's images by the snapshot's OVF. Never
oVirt gerrit 50065 0 ovirt-engine-3.6 MERGED core: Rename parameter cinderDisks to cinderDisksToRestore. Never
oVirt gerrit 50066 0 ovirt-engine-3.6 MERGED core: before unlock a VM, fetch it from the DB Never
oVirt gerrit 50067 0 ovirt-engine-3.6 MERGED core: RestoreCinderSnapshot should delete volumes by order. Never
oVirt gerrit 50068 0 ovirt-engine-3.6 MERGED core: Re-factor restore snapshot for Cinder disks. Never

Internal Links: 1256049

Description Maor 2015-08-23 16:28:35 UTC 
Description of problem:
Commit a previewed snapshot with Cinder disk which has "children" snapshots does not remove all the "children" snapshots after the snapshot gets committed

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Create a VM with Cinder disk
2. Create a snapshot (Lets call it snapshot A)
3. Create another snapshot (Lets call it snapshot B)
4. Create another snapshot (Lets call it snapshot C)
5. preview snapshot A
6. Commit the previewed snapshot

Actual results:
Snapshot gets committed but the snapshot B and C are still existing

Expected results:
When snapshot A gets committed, snapshot B and C should get deleted.

Additional info:
Comment 1 Red Hat Bugzilla Rules Engine 2015-10-19 10:54:04 UTC 
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Comment 2 Yaniv Lavi 2015-10-29 12:30:42 UTC 
In oVirt testing is done on single release by default. Therefore I'm removing the 4.0 flag. If you think this bug must be tested in 4.0 as well, please re-add the flag. Please note we might not have testing resources to handle the 4.0 clone.
Comment 3 Sandro Bonazzola 2015-12-23 13:44:21 UTC 
oVirt 3.6.2 RC1 has been released for testing, moving to ON_QA
Note You need to log in before you can comment on or make changes to this bug.