Bug 1261851 - Cluster cpu type can't be edited
Summary: Cluster cpu type can't be edited
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Virt
Version: ---
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ovirt-3.6.2
: 3.6.2
Assignee: jniederm
QA Contact: Ilanit Stein
URL:
Whiteboard:
: 1288116 1288122 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-09-10 10:16 UTC by jniederm
Modified: 2016-02-18 11:17 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Feature: (rather bug-fix) Setting 'CPU type' in freshly created cluster causes NPE. It was fixed without other functionality changes. Reason: Result:
Clone Of:
Environment:
Last Closed: 2016-02-18 11:17:28 UTC
oVirt Team: Virt
Embargoed:
michal.skrivanek: ovirt-3.6.z?
rule-engine: planning_ack?
ofrenkel: devel_ack+
rule-engine: testing_ack+

Attachments (Terms of Use)
stack-trace.txt (15.24 KB, text/plain)
2015-09-10 10:16 UTC, jniederm 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 45988 0 master MERGED core: Fix of NPE in UnsupportedVmCpuClusterEditChecker Never
oVirt gerrit 46001 0 ovirt-engine-3.6 MERGED core: Fix of NPE in UnsupportedVmCpuClusterEditChecker Never
oVirt gerrit 48171 0 None None None Never
oVirt gerrit 50017 0 ovirt-engine-3.6 MERGED engine: Fix NPE in edit cluster Never

Description jniederm 2015-09-10 10:16:45 UTC 
Created attachment 1072079 [details]
stack-trace.txt

Description of problem:
... probably only if none cpu type is currently set (fresh cpu installation).

Version-Release number of selected component (if applicable):
4.0 master, commit 26ae556

How reproducible:
100%

Steps to Reproduce:
1. Clear engine installation without hosts
2. Open "Default" cluster edit dialog
3. Set CPU type
4. click ok

Actual results:
stacktrace in engine log, cpu type not saved

Expected results:
cpu type saved without errors
Comment 1 Ilanit Stein 2015-11-05 14:50:15 UTC 
Verified on rhevm 3.6.0-18

cpu type updated with no problem.

No stacktrace on engine.log:

[20195bd9] Running command: UpdateVdsGroupCommand internal: false. Entities affected :  ID: 00000002-0002-0002-0002-00000000006a Type: VdsGroupsAction group EDIT_CLUSTER_CONFIGURATION with role type ADMIN
2015-11-05 14:47:30,585 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp-/127.0.0.1:8702-7) [20195bd9] Correlation ID: 20195bd9, Call Stack: null, Custom Event ID: -1, Message: Host cluster Default was updated by admin@internal
Comment 2 Sandro Bonazzola 2015-11-27 07:54:18 UTC 
Since oVirt 3.6.0 has been released, moving from verified to closed current release.
Comment 3 Piotr Kliczewski 2015-12-04 14:09:59 UTC 
The issue still exists on master and 3.6.
Comment 4 Red Hat Bugzilla Rules Engine 2015-12-04 14:10:01 UTC 
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Comment 5 Piotr Kliczewski 2015-12-04 14:13:21 UTC 
*** Bug 1288122 has been marked as a duplicate of this bug. ***
Comment 6 Michal Skrivanek 2015-12-04 15:57:08 UTC 
The new occurence also happens because there was no CPU type set - a brand new Cluster without any host
Comment 7 Red Hat Bugzilla Rules Engine 2015-12-04 15:57:12 UTC 
This bug is not marked for z-stream, yet the milestone is for a z-stream version, therefore the milestone has been reset.
Please set the correct milestone or add the z-stream flag.
Comment 8 jniederm 2015-12-07 15:31:14 UTC 
Steps to Reproduce (for 1st re-open):
1. Clear engine installation without hosts
2. Open "Default" cluster edit dialog
3. Untick "Enable Virt Service"
4. Tick "Enable Gluster Service"
4. Click Ok
Comment 9 Oved Ourfali 2015-12-08 09:25:36 UTC 
*** Bug 1288116 has been marked as a duplicate of this bug. ***
Comment 10 Sandro Bonazzola 2015-12-22 11:02:52 UTC 
Can you please add some doc-text?
Comment 11 Sandro Bonazzola 2015-12-23 15:07:39 UTC 
This bug has target milestone 3.6.2 and is on modified without a target release.
This may be perfectly correct, but please check if the patch fixing this bug is included in ovirt-engine-3.6.2. If it's included, please set target-release to 3.6.2 and move to ON_QA. Thanks.
Comment 12 jniederm 2016-01-04 13:21:43 UTC 
Doc-text added. 
However attached patches are mere bug-fixes so I doubt it is somehow beneficial.
Comment 13 jniederm 2016-01-04 13:34:21 UTC 
Patches http://gerrit.ovirt.org/50017 and http://gerrit.ovirt.org/46001 are in virt-engine-3.6.2 tag.
Comment 14 Ilanit Stein 2016-01-20 11:30:07 UTC 
Verified on rhevm 3.6.2.5-0.1.el6.

Followed reproduce steps in comment #8.
and in addition set the cpu type to "Intel Conroe Family" 
No stacktrace was seen on engine.log
Note You need to log in before you can comment on or make changes to this bug.