Hi Ilya,

does it actually build in Koji? I am asking since I see BR: rubygem(bundler) but no other treatment. This typically means that some dependencies are pulled in during build, but this is not possible on Koji, since it has no network access.

ilgrad's scratch build of rubygem-generator_spec-0.9.3-1.fc24.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11264561

Hi Vit,

everything seems fine with this package. What will be next steps?

Ok, thx. I'll take it for a review.

* Consider excluding dot file using wildcard
  - This is not a blocker, but you might want to exclude all the dot files in
    once using:

      %exclude %{gem_instdir}/.*

    Of course this might be rather big hammer, so this is just for your
    consideration.

* Exclude .gemspec
  - Since the .gemspec you are including in the -doc subpackage is not the
    original one (it is the rewritten version created in %prep section), I would
    suggest to simply exclude the file from package.

* Avoid Bundler dependency
  - Although the Bundler is working just OK in this case, I would still
    recommend to avoid this dependency. It is as easy as modify the %check
    section in this way:

      sed -i "/require 'bundler/ s/^/#/" spec/spec_helper.rb
      rspec -rpathname -Ilib spec

    This might help in case that Fedora is bootstrapped for example. You can
    build this package sooner and possibly avoid some circular dependencies etc.

* Remove unnecessary dependencies
  - The BR: rubygem(activesupport) is not really needed, since it is pulled in
    via rubygem(railties) dependency.
  - In case you decide to avoid the Bundler dependency, you can remove
    BR: rubygem(bundler) as well.


Nevertheless, since all the above are just minor nits, I APPROVE the package.

Thank you Vit!

I will try to continue to consider these comments.

Spec URL: http://repo.clanwars.org/gitlab/rubygem-generator_spec.spec
SRPM URL: http://repo.clanwars.org/gitlab/rubygem-generator_spec-0.9.3-2.fc24.src.rpm

ilgrad's scratch build of rubygem-generator_spec-0.9.3-2.fc24.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11266041

(In reply to Ilya Gradina from comment #6)
> Spec URL: http://repo.clanwars.org/gitlab/rubygem-generator_spec.spec

Looks perfect now! Thx.

BTW it seems that you are looking for more reviews. It is probably worth to try to ask for review swap on fedora-devel or ruby-sig ML ... or probably both ;) And you can also finish your informal reviews (if there is some response).

Ilya, this package was approved, you can continue with scm request ....

Hi Vit,

I was refused.
https://admin.fedoraproject.org/pkgdb/packager/ilgrad/requests

(In reply to Ilya Gradina from comment #11)
I asked pingou on IRC about this issue and there seems to be bug somewhere:

-pingou- vondruch: seems to be a bug in the script: ! User upstrea
>pingou< m-release-monitoring is not a packager
 the person running the script shouldn't have had a problem with this...
>vondruch< pingou, ok ... and the solution is?
-pingou- vondruch: asking again sounds like the correct solution
>vondruch< pingou, ok ... he did that, so hopefully it will pass next time :)
-pingou- vondruch: I removed the old entry, I know there is a bug in this part of the code
* pingou working on fixing it

tl;dr you don't need to do anything ATM and it should hopefully pass next time.

Ilya, please close the review tickets once you import and build the package. Thx.