Created attachment 1076536 [details] Engine log with the NPE. Description of problem: When editing cluster and no "CPU Type" is specified a Null Pointer Exception is thrown instead of giving an error message. Version-Release number of selected component (if applicable): How reproducible: 100% Steps to Reproduce: 1.Run clean version of engine. 2.Go to Clusters tab. 3.Click "Edit" on "Default" cluster. 4.Click OK(Don't change the CPU Type. It should be blank). Actual results: Edit dialog doesn't close but no error message specified in UI. In the engine.log you may see that NullPointerException was thrown. Expected results: Error message should appear saying: "No CPU Type specified". Additional info:
Tomer: 1. Please (next time) post the NPE stack trace (first few lines) within the bug. It provides the developer a quick way to try and get a hint where the issue is, and it allows easier search for duplicates. Example: 2015-09-24 15:46:29,168 ERROR [org.ovirt.engine.core.bll.GetClusterEditWarningsQuery] (default task-27) [] Query 'GetClusterEditWarningsQuery' failed: null 2015-09-24 15:46:29,168 ERROR [org.ovirt.engine.core.bll.GetClusterEditWarningsQuery] (default task-27) [] Exception: java.lang.NullPointerException at org.ovirt.engine.core.bll.UnsupportedVmCpuClusterEditChecker.isApplicable(UnsupportedVmCpuClusterEditChecker.java:23) [bll.jar:] at org.ovirt.engine.core.bll.UnsupportedVmCpuClusterEditChecker$Proxy$_$$_WeldClientProxy.isApplicable(Unknown Source) [bll.jar:] at org.ovirt.engine.core.bll.GetClusterEditWarningsQuery.getApplicableChecks(GetClusterEditWarningsQuery.java:100) [bll.jar:] at org.ovirt.engine.core.bll.GetClusterEditWarningsQuery.getProblematicEntities(GetClusterEditWarningsQuery.java:74) [bll.jar:] at org.ovirt.engine.core.bll.GetClusterEditWarningsQuery.executeQueryCommand(GetClusterEditWarningsQuery.java:56) [bll.jar:] at org.ovirt.engine.core.bll.QueriesCommandBase.executeCommand(QueriesCommandBase.java:100) [bll.jar:] at org.ovirt.engine.core.dal.VdcCommandBase.execute(VdcCommandBase.java:33) [dal.jar:] at org.ovirt.engine.core.bll.Backend.runQueryImpl(Backend.java:539) [bll.jar:] at org.ovirt.engine.core.bll.Backend.runQuery(Backend.java:513) [bll.jar:] at sun.reflect.GeneratedMethodAccessor76.invoke(Unknown Source) [:1.7.0_79] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [rt.jar:1.7.0_79] at java.lang.reflect.Method.invoke(Method.java:606) [rt.jar:1.7.0_79] at org.jboss.as.ee.component.ManagedReferenceMethodInterceptor.processInvocation(ManagedReferenceMethodInterceptor.java:52) at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:309) at org.jboss.invocation.WeavedInterceptor.processInvocation(WeavedInterceptor.java:53) at org.jboss.as.ee.component.interceptors.UserInterceptorFactory$1.processInvocation(UserInterceptorFactory.java:63) at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:309) at org.jboss.invocation.InterceptorContext$Invocation.proceed(InterceptorContext.java:407) at org.jboss.as.weld.ejb.Jsr299BindingsInterceptor.delegateInterception(Jsr299BindingsInterceptor.java:70) [wildfly-weld-8.2.0.Final.jar:8.2.0.Final] at org.jboss.as.weld.ejb.Jsr299BindingsInterceptor.doMethodInterception(Jsr299BindingsInterceptor.java:80) [wildfly-weld-8.2.0.Final.jar:8.2.0.Final] at org.jboss.as.weld.ejb.Jsr299BindingsInterceptor.processInvocation(Jsr299BindingsInterceptor.java:93) [wildfly-weld-8.2.0.Final.jar:8.2.0.Final] at org.jboss.as.ee.component.interceptors.UserInterceptorFactory$1.processInvocation(UserInterceptorFactory.java:63) 2. Is this a regression?
Yes this is regression. It didn't happen before this version.
(In reply to Tomer Saban from comment #2) > Yes this is regression. It didn't happen before this version. - Where's the regression keyword? - Which version is that?
I added the regression keyword. Version is 4.0 as stated.
Found on commit hash: 68c845eddce3a7bb6082431e725d44f5588c7d9c
This bug report has Keywords: Regression or TestBlocker. Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Can not reproduce on master following scenario in bug description, please check scenario again on latest master and verify or provide additional details how to reproduce