Red Hat Bugzilla – Bug 1269592
[Docs] [Director] Wrong path to storage-environment.yaml in overcloud deploy command
Last modified: 2016-01-17 18:23:20 EST
The Director Install and Config guide states this in section 6.3.6:
"We also include environments/storage-environment.yaml in our deployment to initiate our storage requirements."
But in section 6.3.8 it uses this in the overcloud deploy command line [fix this part]:
openstack overcloud deploy --templates ~/templates/my-overcloud -e ~/templates/my-overcloud/environments/network-isolation.yaml -e ~/templates/network-environment.yaml -e ~/templates/storage-environment.yaml --control-scale 3 ...
Then 5 lines later this, again:
"-e ~/templates/my-overcloud/environments/storage-environment.yaml - The -e option adds an additional environment ..."
Actually, all through section 6.3 the ~/templates/my-overcloud/ path is used inconsistently: sometimes the files are in ~/templates/my-overcloud/foo.yaml, and sometimes they're in ~/templates/bar.yaml.
Considering that in section 6.3.5, there is this:
$ cp -r /usr/share/openstack-tripleo-heat-templates ~/templates/my-overcloud
All paths to templates should contain the 'my-overcloud' directory.
(In reply to Dan Yocum from comment #2)
> Actually, all through section 6.3 the ~/templates/my-overcloud/ path is used
> inconsistently: sometimes the files are in
> ~/templates/my-overcloud/foo.yaml, and sometimes they're in
> Considering that in section 6.3.5, there is this:
> $ cp -r /usr/share/openstack-tripleo-heat-templates ~/templates/my-overcloud
> All paths to templates should contain the 'my-overcloud' directory.
Errrr. That should read
"All paths to templates should contain the 'my-overcloud' directory in the rest of this section."
I need more coffee.... :/
Assigning to Dan for review.
Per our IRC conversation, I'll work with dsneddon to create a network-environment.yaml file that should get shipped in the /usr/share/openstack-tripleo-heat-templates/environments/ dir with the rest of the environment files.
No prob. In the meantime, I've corrected the sotrage-environment.yaml location:
How does it look, Dan? Can you spot anything else in that section that requires a change?
The my-overcloud fix looks good.
Personally, I think the network-environments.yaml file should go in ~/templates/my-overcloud/environments/ dir like the other environment files.
What do you think?
This is part of a larger problem that I'll need to solve.
At some stage the user might need to remove the custom templates collection and replace it with an updated version from /usr/share/openstack-tripleo-heat-templates. I'm concerned that any additional files from the user might get deleted if they try to replace the custom templates collection.
Having said that, the end user still needs to diff between the customer template collection and the default version when performing updates, so there's still the difficulty with identifying template differences.
What I think is the probably best course of action is if in the future I document some form of version control (i.e. git) to manage the custom template collection. That way you can add new files, make changes, and sync with the default version when it gets updated.
Yes, I agree there is a larger problem to solve, but let me open an RFE BZ and let's discuss it there - you can close this BZ.
Assigning Radek as the QA contact.
Radek - could you take a look at the changes for this bug?
Looks good to me too.
This content is live on the Customer Portal.