Created attachment 1085092 [details] vdsm log Description of problem: [SR-IOV] - vdsm.log is spammed with KeyError: 'net.0.name' error messages while running VM with 'pci-passthrough' vNIC/s. Thread-88::ERROR::2015-10-21 14:11:03,494::vm::1390::virt.vm::(_getRunningVmStats) vmId=`cde9bf57-cfd7-4dd2-9ce3-592a75e67f75`::Error fetching vm stats Traceback (most recent call last): File "/usr/share/vdsm/virt/vm.py", line 1387, in _getRunningVmStats vm_sample.interval) File "/usr/share/vdsm/virt/vmstats.py", line 42, in produce networks(vm, stats, first_sample, last_sample, interval) File "/usr/share/vdsm/virt/vmstats.py", line 213, in networks first_indexes = _find_bulk_stats_reverse_map(first_sample, 'net') File "/usr/share/vdsm/virt/vmstats.py", line 340, in _find_bulk_stats_reverse_map name_to_idx[stats['%s.%d.name' % (group, idx)]] = idx KeyError: 'net.0.name' - This error is shown and filled the vdsm.log every minute while the VM is running with 'pci-passthrough' vNIC/s, cause vdsm trying to monitor and get VMstats, but failing to do so. Version-Release number of selected component (if applicable): 3.6.0.1-0.1.el6.noarch vdsm-4.17.9-1.el7ev.noarch Steps to Reproduce: 1. Run VM with VFs - 'pci-passthough' vNIC/s 2. less /var/log/vdsm/vdsm.log Actual results: vdsm.log is spammed with errors. Expected results: vdsm.log shouldn't be spammed with such errors.
When there is a direct pass through device attached to a vm, libvirt cannot report any statistics on it, but still count it in the context of statistics, which made vdsm expect the statistics was there. Since this is a documented behavior in https://libvirt.org/html/libvirt-libvirt-domain.html#virConnectGetAllDomainStats , vdsm should be defensive and treat this number (in this case "net.count") more as an upper bound.
In oVirt testing is done on single release by default. Therefore I'm removing the 4.0 flag. If you think this bug must be tested in 4.0 as well, please re-add the flag. Please note we might not have testing resources to handle the 4.0 clone.
Please set target release or I can't move the bug to ON_QA automatically.
Bug tickets that are moved to testing must have target release set to make sure tester knows what to test. Please set the correct target release before moving to ON_QA.
Verified on - 3.6.1-0.2.el6 and vdsm-4.17.11-0.el7ev.noarch
According to verification status and target milestone this issue should be fixed in oVirt 3.6.1. Closing current release.