Bug 1284150 - [PATCH] Use regular variables for git sources
Summary: [PATCH] Use regular variables for git sources
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: docker
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Lokesh Mandvekar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-11-21 03:14 UTC by Colin Walters
Modified: 2015-12-08 15:36 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-12-08 15:36:53 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
0001-Use-regular-variables-for-git-sources.patch (9.03 KB, patch)
2015-11-21 03:14 UTC, Colin Walters
no flags Details | Diff
rebased (9.02 KB, patch)
2015-12-08 15:32 UTC, Colin Walters
no flags Details | Diff

Description Colin Walters 2015-11-21 03:14:03 UTC
Created attachment 1097418 [details]
0001-Use-regular-variables-for-git-sources.patch

The current https://fedoraproject.org/wiki/Packaging:SourceURL spec
suggests using e.g. `commit0` for the git commit variable.  The
implication of this is that e.g. `Source0` uses `commit0`, `Source1`
uses `commit1` etc.

Move things this way so that the sources that come from git
repositories (docker, docker-selinux, docker-storage-setup,
docker-utils) are ordered first and consistently named.

What I plan to do next is enhance
https://github.com/cgwalters/rpmdistro-gitoverlay to understand how to
fetch all component git repositories here.
---
 .gitignore  |  2 ++
 docker.spec | 93 +++++++++++++++++++++++++++++++++----------------------------
 sources     |  2 +-
 3 files changed, 53 insertions(+), 44 deletions(-)

Comment 1 Colin Walters 2015-11-24 19:57:30 UTC
This is still outstanding; Lokesh you were ok with this?  Can you rebase or do you want me to?

Comment 2 Colin Walters 2015-12-08 15:32:01 UTC
Created attachment 1103639 [details]
rebased

Comment 3 Colin Walters 2015-12-08 15:36:53 UTC
IRC review from lsm5+.


Note You need to log in before you can comment on or make changes to this bug.