Bug 1288476 - Review Request: vagrant-adbinfo - Connection and configuration for a Docker daemon
Summary: Review Request: vagrant-adbinfo - Connection and configuration for a Docker d...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Josef Stribny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-12-04 11:15 UTC by Pavel Valena
Modified: 2016-01-04 05:54 UTC (History)
3 users (show)

Fixed In Version: vagrant-adbinfo-0.0.9-3.fc24.src.rpm
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-12-04 12:20:53 UTC
Type: Bug
Embargoed:
jstribny: fedora-review+

Attachments (Terms of Use)

Description Pavel Valena 2015-12-04 11:15:00 UTC 
Spec URL: https://pvalena.fedorapeople.org/gems/vagrant-adbinfo.spec
SRPM URL: https://pvalena.fedorapeople.org/gems/vagrant-adbinfo-0.0.9-2.fc24.src.rpm
Description: Vagrant plugin that provides the IP address:port and TLS certificate file location for a Docker daemon.
Fedora Account System Username: pvalena
Comment 1 Josef Stribny 2015-12-04 11:48:06 UTC 
I found 2 minor issues:

* Upstream URL is https://github.com/projectatomic/vagrant-adbinfo
* BuildRequires on Ruby are not necessary, Vagrant pulls CRuby already
Comment 2 Pavel Valena 2015-12-04 12:14:10 UTC 
Issues fixed.

Spec URL: https://pvalena.fedorapeople.org/gems/vagrant-adbinfo.spec
SRPM URL: https://pvalena.fedorapeople.org/gems/vagrant-adbinfo-0.0.9-3.fc24.src.rpm
Comment 3 Josef Stribny 2015-12-04 12:17:30 UTC 
The package builds, runs, installs. Specfile looks good.

=> APPROVED.
Comment 4 Pavel Valena 2015-12-04 12:20:53 UTC 
Thank you.
Comment 5 Gwyn Ciesla 2015-12-04 13:27:04 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/vagrant-adbinfo
Note You need to log in before you can comment on or make changes to this bug.