Description of problem: In 3.6 we introduced a dependency to glusterfs-cli. This is required in order to get gluster volume info needed to get gluster backup servers and replica related logic. During upgrade, if glusterfs-cli is not installed, there is a not-completely clear exception in the log: jsonrpc.Executor/5::ERROR::2015-12-12 16:30:56,068::hsm::2476::Storage.HSM::(connectStorageServer) Could not connect to storageServer Traceback (most recent call last): File "/usr/share/vdsm/storage/hsm.py", line 2473, in connectStorageServer conObj.connect() File "/usr/share/vdsm/storage/storageServer.py", line 222, in connect self.validate() File "/usr/share/vdsm/storage/storageServer.py", line 337, in validate replicaCount = self.volinfo['replicaCount'] File "/usr/share/vdsm/storage/storageServer.py", line 333, in volinfo self._volinfo = self._get_gluster_volinfo() File "/usr/share/vdsm/storage/storageServer.py", line 362, in _get_gluster_volinfo self._volfileserver) File "/usr/lib/python2.7/site-packages/vdsm/supervdsm.py", line 51, in __call__ return callMethod() File "/usr/lib/python2.7/site-packages/vdsm/supervdsm.py", line 49, in <lambda> **kwargs) File "<string>", line 2, in glusterVolumeInfo File "/usr/lib64/python2.7/multiprocessing/managers.py", line 773, in _callmethod raise convert_to_error(kind, result) GlusterCmdExecFailedException: Command execution failed In this case, we'd like to add a warning message in the log clearly indicating missing glustefs-cli package. How reproducible: 100% Steps to Reproduce: 1. Install 3.5 2. Add gluster sd 3. Upgrade to 3.6 Actual results: Cannot connect to gluster Expected results: Upgrade to successfully pass
The error seen here does not mean the glusterfs-cli package is missing, so we cannot replace the error with a warning. If we want to warn about missing package, we should check if the package is available, and if not, warn about it and continue to work as we did in rhev 3.5 (no automatic backup servers). But the real fix is to require the package on the platform which provide it.
Vdsm reports (in Caps) whether glusterfs-cli is installed on the host. Engine should be smart enough not to allow a host without it into a 3.6 cluster with a gluster SD.
Dan, I think the issue is older engine that does not know anything about gluster availability. In 3.6 would not let you add such host to a cluster or upgrade the cluster if a host in the cluster does not have the required packages. These packages are needed now because 3.6 try to provide more reliable mounting by getting information about the gluster volume. Seems that we can try this improved mounting only if gluster is available.
Two different things: 1. In 3.6 the engine does check Vdsm Caps and alerts ifrequired gluster packages are missing 2. In this bug, we would like to warn the admin, mainly when upgrading from 3.5, that required gluster packages are missing.
oVirt 3.6.2 RC1 has been released for testing, moving to ON_QA
Ala, please handle the doctext.
After upgrading host cluster and DC from 3.5 to 3.6 while having an active Gluster domain and no gluster-cli package installed on the host, I got the following warning in vdsm.log: jsonrpc.Executor/3::WARNING::2016-02-07 17:12:03,556::storageServer::338::Storage.StorageServer.MountConnection::(validate) Required glusterfs-cli package is missing on this host. Note that automatic detection of backup servers will be disabled! Please install the missing package in order to automatically mount gluster storage backup servers Ala, can you please confirm so I'll move to VERIFIED? Thanks Checked using: vdsm-4.17.19-0.el7ev.noarch glusterfs-3.7.1-16.el7.x86_64 rhevm-3.6.3-0.1.el6.noarch
The message is expected. Assuming the domain is still active after the upgrade, go ahead and move the bug to VERIFIED.
Indeed, the domain is active after the upgrade. Thanks, moving to VERIFIED.