I find that I'd really like smartd to spam me daily if it finds any issues, in case I happen to miss one notice. Without persistence, smartd it seems will only warn me the first time it sees something wrong with a drive and won't notify again (until a fresh boot) even if something additional goes wrong. I can understand if enabling persistence by default is too much, but could you consider including in the package a location for persistence data (i.e just make a directory /var/lib/smartmontools)? Perhaps add a comment in /etc/sysconfig/smartmontools as well. This way there will be a standard location for the data, which could also be added to selinux policy. Thanks. If I have another few minutes I'll work up a patch.
Created attachment 1165337 [details] Trivial patch I guess I forgot to get back to this, but here's a trivial patch which adds /var/lib/smartmontools to the package. The selinux policy appears to account for this already: /var/lib/smartmontools(/.*)? all files system_u:object_r:fsdaemon_var_lib_t:s0 so I don't see any reason not to at least have smartmontools create it and mention it in the sysconfig file.
Created attachment 1165406 [details] Proper patch Would be good if I actually sent the right patch. Sorry for the spam. BTW, I will be happy to commit this for you.
build for rawhide for other fedora versions, updates were build, but won't be pushed as updates until there is something bigger
Cool, thanks!
Hi! I may be mistaken, but it seems to me that creating /var/lib/smartmontools automatically makes smartd write in it. At least if I believe this report https://github.com/xcp-ng/xcp/issues/137. I can't test myself easily but figured I'd tell you just in case, because I think that was not on purpose (at least, again, if I'm right).