Bug 1292371 - vdsm logs the wrong xml when dehibernating
Summary: vdsm logs the wrong xml when dehibernating
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: Core
Version: 4.17.11
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ovirt-3.6.2
: 4.17.15
Assignee: Francesco Romani
QA Contact: sefi litmanovich
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-12-17 08:39 UTC by Francesco Romani
Modified: 2016-02-18 11:18 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-02-18 11:18:48 UTC
oVirt Team: Virt
Embargoed:
danken: ovirt-3.6.z?
rule-engine: planning_ack?
rule-engine: devel_ack+
rule-engine: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 49139 0 ovirt-3.6 MERGED vm: fix misleading XML log 2015-12-22 12:34:34 UTC

Description Francesco Romani 2015-12-17 08:39:54 UTC 
Description of problem:
When dehibernating (aka restoring state aka migrating from file) VDSM logs the wrong XML.
The XML being logged is the one which would be created if the VM will be started from scratch again, not the one actually used, and store in the VM state.

Version-Release number of selected component (if applicable):
4.17.x

How reproducible:
100%

Steps to Reproduce:
1. hibernate a VM
2. dehibernate a VM
3. check the logs, compare what Vdsm logs to what Vdsm stored in the recovery file, and to what libvirt sees (virsh -r dumpxml $DOMAIN)

Actual results:
wrong (and meaningless) XML is logged

Expected results:
Vdsm logs the actual XML it sent to libvirt

Additional info:
This change affects only logging, to help troubleshooting. No changes in flow.
Comment 1 Sandro Bonazzola 2015-12-23 15:00:52 UTC 
QE note, not in vdsm-4.17.14
Comment 2 Barak Korren 2015-12-29 14:48:59 UTC 
RHEV build 3.6.2-3 released
http://bob.eng.lab.tlv.redhat.com/builds/3.6/3.6.2-3/
Comment 3 sefi litmanovich 2016-01-07 13:26:42 UTC 
Verified with rhevm-3.6.2-0.1.el6.noarch on both vdsm-4.17.14-0.el7ev.noarch and vdsm-4.17.15-0.el7ev.noarch hosts.

In both cases after hibernate and de-hibernate the xml in vdsm log correlates to the xml from qemu.
Comment 4 sefi litmanovich 2016-01-07 13:27:01 UTC 
Verified with rhevm-3.6.2-0.1.el6.noarch on both vdsm-4.17.14-0.el7ev.noarch and vdsm-4.17.15-0.el7ev.noarch hosts.

In both cases after hibernate and de-hibernate the xml in vdsm log correlates to the xml from qemu.
Note You need to log in before you can comment on or make changes to this bug.