Bug 1297133 - useless lpf package created because lpf-setup-pkg messes up in the presence of backup files
Summary: useless lpf package created because lpf-setup-pkg messes up in the presence o...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: lpf
Version: 34
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Sergio Basto
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-01-09 17:24 UTC by barsnick
Modified: 2021-10-29 23:02 UTC (History)
2 users (show)

Fixed In Version: lpf-0.3-1.fc33 lpf-0.3-1.fc34 lpf-0.3-1.el8 lpf-0.3-1.fc35
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-10-17 21:24:04 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description barsnick 2016-01-09 17:24:34 UTC
Description of problem:
When a backup file of pkgname.spec.in is present next to it (because of the latest edit), such as pkgname.spec.in~, lpf-setup-pkg doesn't copy the spec file to the lpf-packagename SRC RPM while building it, creating a useless lpf-pkgname package. lpf build does nothing, even though a newer lpf package is installed. It just silently exits, without checking versions and complaining about a missing spec file.

Version-Release number of selected component (if applicable):
lpf-0.2-1.f1f5dd9

How reproducible:


Steps to Reproduce:
1. Edit ~/rpmbuild/SOURCES/flash-plugin.spec.in, creating an additional backup file ~/rpmbuild/SOURCES/flash-plugin.spec.in~
2. Edit ~/rpmbuild/SPECS/lpf-flash-plugin.spec
3. rpmbuild -ba ~/rpmbuild/SPECS/lpf-flash-plugin.spec
4. dnf install ~/rpmbuild/RPMS/x86_64/lpf-flash-plugin-11.2.202.559-0.fc22.1sunshine.x86_64.rpm
5. lpf state flash-plugin
6. lpf build flash-plugin


Actual results:
Nothing

Expected results:
Builds new flash-plugin package

Additional info:
Note that the output of 3., as used in 4., does not contain flash-plugin.spec. This is due to this line in /usr/share/lpf/scripts/lpf-setup-pkg failing:

cp -a $spec* $topdir/usr/share/lpf/packages/$pkg/${pkg}.spec

This copies one file to a new filename and location. It fails if the wildcards expands to more than one file.

Why not express exactly what needs to be done (the source file name is well known, no need for a wildcard):

cp -a ${spec}.in $topdir/usr/share/lpf/packages/$pkg/${pkg}.spec

Comment 1 Fedora End Of Life 2016-07-19 18:38:55 UTC
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 2 Sergio Basto 2020-11-11 00:25:03 UTC
I'd like check the bug, soon.

Comment 3 Ben Cotton 2021-02-09 15:05:50 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.

Comment 4 Fedora Update System 2021-10-10 00:18:15 UTC
FEDORA-2021-e89aff3128 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e89aff3128

Comment 5 Fedora Update System 2021-10-10 00:18:32 UTC
FEDORA-2021-86e4837cee has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-86e4837cee

Comment 6 Fedora Update System 2021-10-10 00:18:49 UTC
FEDORA-2021-d655861edd has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-d655861edd

Comment 7 Fedora Update System 2021-10-10 03:46:58 UTC
FEDORA-2021-d655861edd has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-d655861edd`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-d655861edd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-10-10 03:49:43 UTC
FEDORA-2021-86e4837cee has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-86e4837cee`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-86e4837cee

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-10-10 17:41:10 UTC
FEDORA-2021-e89aff3128 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-e89aff3128`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e89aff3128

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2021-10-11 11:13:38 UTC
FEDORA-EPEL-2021-b81b53b69f has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-b81b53b69f

Comment 11 Fedora Update System 2021-10-11 21:53:34 UTC
FEDORA-EPEL-2021-b81b53b69f has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-b81b53b69f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2021-10-17 21:24:04 UTC
FEDORA-2021-d655861edd has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2021-10-17 21:58:33 UTC
FEDORA-2021-86e4837cee has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2021-10-19 01:00:13 UTC
FEDORA-EPEL-2021-b81b53b69f has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2021-10-29 23:02:28 UTC
FEDORA-2021-e89aff3128 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.