Bug 1297133 - useless lpf package created because lpf-setup-pkg messes up in the presence of backup files
useless lpf package created because lpf-setup-pkg messes up in the presence o...
Product: Fedora
Classification: Fedora
Component: lpf (Show other bugs)
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Alec Leamas
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2016-01-09 12:24 EST by barsnick
Modified: 2016-07-19 14:38 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2016-07-19 14:38:55 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description barsnick 2016-01-09 12:24:34 EST
Description of problem:
When a backup file of pkgname.spec.in is present next to it (because of the latest edit), such as pkgname.spec.in~, lpf-setup-pkg doesn't copy the spec file to the lpf-packagename SRC RPM while building it, creating a useless lpf-pkgname package. lpf build does nothing, even though a newer lpf package is installed. It just silently exits, without checking versions and complaining about a missing spec file.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Edit ~/rpmbuild/SOURCES/flash-plugin.spec.in, creating an additional backup file ~/rpmbuild/SOURCES/flash-plugin.spec.in~
2. Edit ~/rpmbuild/SPECS/lpf-flash-plugin.spec
3. rpmbuild -ba ~/rpmbuild/SPECS/lpf-flash-plugin.spec
4. dnf install ~/rpmbuild/RPMS/x86_64/lpf-flash-plugin-
5. lpf state flash-plugin
6. lpf build flash-plugin

Actual results:

Expected results:
Builds new flash-plugin package

Additional info:
Note that the output of 3., as used in 4., does not contain flash-plugin.spec. This is due to this line in /usr/share/lpf/scripts/lpf-setup-pkg failing:

cp -a $spec* $topdir/usr/share/lpf/packages/$pkg/${pkg}.spec

This copies one file to a new filename and location. It fails if the wildcards expands to more than one file.

Why not express exactly what needs to be done (the source file name is well known, no need for a wildcard):

cp -a ${spec}.in $topdir/usr/share/lpf/packages/$pkg/${pkg}.spec
Comment 1 Fedora End Of Life 2016-07-19 14:38:55 EDT
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this

Thank you for reporting this bug and we are sorry it could not be fixed.

Note You need to log in before you can comment on or make changes to this bug.