Bug 1297312 - [cinder] revert operation when fail to add Cinder snapshot.
Summary: [cinder] revert operation when fail to add Cinder snapshot.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-3.6.2
: 3.6.2.6
Assignee: Maor
QA Contact: Natalie Gavrielov
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-01-11 07:43 UTC by Maor
Modified: 2016-02-23 13:31 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-02-23 13:31:51 UTC
oVirt Team: Storage
Embargoed:
tnisan: ovirt-3.6.z?
ylavi: planning_ack+
tnisan: devel_ack+
rule-engine: testing_ack?


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 51606 0 master MERGED core: Support revert of new Cinder snapshot. 2016-01-12 13:15:22 UTC
oVirt gerrit 51723 0 ovirt-engine-3.6 MERGED core: Support revert of new Cinder snapshot. 2016-01-13 10:41:26 UTC
oVirt gerrit 51746 0 ovirt-engine-3.6 MERGED core: Add TODO once fix will be backported 2016-01-13 13:02:36 UTC
oVirt gerrit 52355 0 ovirt-engine-3.6.2 MERGED core: Support revert of new Cinder snapshot. 2016-01-18 18:02:25 UTC
oVirt gerrit 52356 0 ovirt-engine-3.6.2 MERGED core: Add TODO once fix will be backported 2016-01-18 18:03:34 UTC

Description Maor 2016-01-11 07:43:51 UTC
Description of problem:
Once a new Cinder snapshot is failed to be created the failed operation should remove all the redundant volumes which were already created for the other Cinder snapshots  in the VM

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Create a VM
2. Create several Cinder disks (5 disks for example)
3. Create a Snapshot
4. Fail the operation so the snapshot will not get created (Even by failing only of one of the volume's snapshot which was created)


Actual results:
The Cinder's snapshots for each Cinder disks are not being removed from Cinder after this failure

Expected results:
All the snapshots which were created in Cinder, for each volume, should be removed from Cinder.

Additional info:

Comment 1 Maor 2016-01-12 17:46:27 UTC
Please consider that for this fix to work on multiple disks the patch with the following change-id I2ca19ec44cba371813381e8f8b076e463eda4173 should be backported.

Until then, this fix should resolve the issue but mainly for one Cinder disk, for multiple disks there might be several corner cases which might not be supported.


Note You need to log in before you can comment on or make changes to this bug.