Bug 1297541 - Deployment names are allowed that are the same except for leading/trailing whitespace
Summary: Deployment names are allowed that are the same except for leading/trailing wh...
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: Red Hat Quickstart Cloud Installer
Classification: Red Hat
Component: WebUI
Version: 1.0
Hardware: All
OS: All
unspecified
medium
Target Milestone: TP3
: 1.0
Assignee: cchase
QA Contact: Landon LaSmith
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-01-11 19:46 UTC by Tasos Papaioannou
Modified: 2019-02-25 17:28 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-25 17:28:52 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Tasos Papaioannou 2016-01-11 19:46:55 UTC
Description of problem:

Deployment names that duplicate existing names, except for leading or trailing whitespace, are allowed on the 1A. Deployment Name tab.

For example, "deployment-1" and "deployment-1 " can both be created. After that, " deployment-1" and "deployment-1  " are also allowed, but clicking "Next" on the 1C. Configure Lifecycle Environment tab silently fails, with an HTTP 422 return code logged in /var/log/foreman/production.log:

****
2016-01-11 14:39:15 [I] Processing by Fusor::Api::V21::DeploymentsController#create as JSON
2016-01-11 14:39:15 [I]   Parameters: {"deployment"=>{"name"=>"deployment-1  ", "description"=>nil, "deploy_rhev"=>true, "deploy_cfme"=>false, "deploy_openstack"=>false, "is_disconnected"=>false, "rhev_is_self_hosted"=>false, "rhev_engine_admin_password"=>"[FILTERED]", "rhev_database_name"=>"Default", "rhev_cluster_name"=>"Default", "rhev_storage_name"=>"my_storage", "rhev_storage_type"=>"NFS", "rhev_storage_address"=>nil, "rhev_cpu_type"=>nil, "rhev_share_path"=>nil, "cfme_install_loc"=>nil, "rhev_root_password"=>"[FILTERED]", "cfme_root_password"=>"[FILTERED]", "cfme_admin_password"=>"[FILTERED]", "foreman_task_uuid"=>nil, "upstream_consumer_uuid"=>nil, "upstream_consumer_name"=>nil, "rhev_export_domain_name"=>"my_export", "rhev_export_domain_address"=>nil, "rhev_export_domain_path"=>nil, "rhev_local_storage_path"=>nil, "rhev_gluster_node_name"=>nil, "rhev_gluster_node_address"=>nil, "rhev_gluster_ssh_port"=>nil, "rhev_gluster_root_password"=>"[FILTERED]", "host_naming_scheme"=>nil, "custom_preprend_name"=>nil, "enable_access_insights"=>false, "cfme_address"=>nil, "cfme_hostname"=>nil, "openstack_undercloud_password"=>"[FILTERED]", "openstack_undercloud_ip_addr"=>nil, "openstack_undercloud_user"=>nil, "openstack_undercloud_user_password"=>"[FILTERED]", "openstack_undercloud_hostname"=>nil, "openstack_overcloud_hostname"=>nil, "openstack_overcloud_address"=>nil, "openstack_overcloud_password"=>"[FILTERED]", "openstack_overcloud_private_net"=>nil, "openstack_overcloud_float_net"=>nil, "openstack_overcloud_float_gateway"=>nil, "cdn_url"=>nil, "manifest_file"=>nil, "created_at"=>nil, "updated_at"=>nil, "rhev_engine_host_id"=>nil, "organization_id"=>"1", "lifecycle_environment_id"=>nil, "discovered_host_id"=>nil, "foreman_task_id"=>nil}, "api_version"=>"v21"}

Version-Release number of selected component (if applicable):

RHCI-6.0-RHEL-7-20160107.t.1

How reproducible:

100%

Steps to Reproduce:
1.) Create a deployment with name "deployment-1".
2.) Create a 2nd deployment with name "deployment-1 ".
3.) Create deployments with names " deployment-1", "deployment-1 ", etc.

Actual results:

Names that are identical except for the number of leading or trailing whitespace characters are allowed.

Expected results:

Deployment names should be visually distinct.

Additional info:

Comment 1 cchase 2016-02-17 21:09:20 UTC
https://github.com/fusor/fusor/pull/683

Comment 2 John Matthews 2016-04-05 13:57:36 UTC
In TP3 RC2

Comment 3 Landon LaSmith 2016-04-08 19:56:45 UTC
Verified in TP3 RC2.

Created valid deployment w/ name "deployment-1"
Failed to create new deployment with names "deployment-1 ", "deployment-1  ", " deployment-1", " deployment-1 ".

QCI responded with: 
"must be unique
generated label "deployment_1" is not unique"

Comment 4 Sudhir Mallamprabhakara 2019-02-25 17:28:52 UTC
QCI has sunset. Closing the BZ's


Note You need to log in before you can comment on or make changes to this bug.