Bug 1298310 - Review Request: nodejs-validate-npm-package-license - Give me a string and I'll tell you if it's a valid npm package license string
Review Request: nodejs-validate-npm-package-license - Give me a string and I'...
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Zbigniew Jędrzejewski-Szmek
Fedora Extras Quality Assurance
:
Depends On: 1298269 1298301
Blocks: nodejs-reviews
  Show dependency treegraph
 
Reported: 2016-01-13 13:04 EST by Jared Smith
Modified: 2016-01-15 07:47 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-01-15 07:47:32 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
zbyszek: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Jared Smith 2016-01-13 13:04:54 EST
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-validate-npm-package-license/nodejs-validate-npm-package-license.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-validate-npm-package-license/nodejs-validate-npm-package-license-3.0.1-1.fc24.src.rpm
Description: Give me a string and I'll tell you if it's a valid npm package license string
Fedora Account System Username: jsmith
Comment 1 Zbigniew Jędrzejewski-Szmek 2016-01-13 17:00:21 EST
You should shorten the summary to standard 70 chars, even though I have to admit it is cute.

%description should end in ".".

+ license is acceptable (apache 2)
+ license is correctly specified
+ license file is present, %license is used
+ latest version
+ builds and installs OK
+ provides and requires look sane
+ %check passes
+ fedora-review is happy

Package is APPROVED.
Comment 2 Zbigniew Jędrzejewski-Szmek 2016-01-13 17:00:49 EST
rpmlint:
Checking: nodejs-validate-npm-package-license-3.0.1-1.fc24.noarch.rpm
          nodejs-validate-npm-package-license-3.0.1-1.fc24.src.rpm
nodejs-validate-npm-package-license.noarch: W: only-non-binary-in-usr-lib
nodejs-validate-npm-package-license.noarch: W: dangling-symlink /usr/lib/node_modules/validate-npm-package-license/node_modules/spdx-expression-parse /usr/lib/node_modules/spdx-expression-parse
nodejs-validate-npm-package-license.noarch: W: dangling-symlink /usr/lib/node_modules/validate-npm-package-license/node_modules/spdx-correct /usr/lib/node_modules/spdx-correct
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

All OK.
Comment 3 Patrick Uiterwijk 2016-01-14 18:14:07 EST
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/nodejs-validate-npm-package-license

Note You need to log in before you can comment on or make changes to this bug.