Hide Forgot
Description of problem: numanodes tag not working right Version-Release number of selected component (if applicable): beaker-client-22.0-2.el7sed.noarch How reproducible: always Steps to Reproduce: 1. submit a job with numanodes in job # bkr workflow-simple --hostrequire="numanodes >= 2" --debug --distro="RHEL-7.2-20151030.0" --task="/distribution/dummy" --prettyxml --arch="x86_64" <job retention_tag="Scratch"> <whiteboard></whiteboard> <recipeSet priority="Normal"> <recipe ks_meta="" whiteboard=""> <distroRequires> <and> <distro_name op="=" value="RHEL-7.2-20151030.0"/> <distro_arch op="=" value="x86_64"/> </and> </distroRequires> <hostRequires> <and> <numanodes op=">=" value="2"/> </and> </hostRequires> <repos/> <partitions/> <task name="/distribution/install" role="STANDALONE"> <params/> </task> <task name="/distribution/dummy" role="STANDALONE"> <params/> </task> </recipe> </recipeSet> </job> Submitted: ['J:1196383'] 2. check beaker job the machine got is only with 1 numa node 3. Actual results: numanodes did not work Expected results: should work Additional info:
Thanks for your report. Looks like there is a mistake in the hostrequires paramater. You can request either by: --hostrequire '<system><numanodes ..></system' which is the recommended way or by: --hostrequire 'numa_node_count >= 2' which is deprecated but still works. Would you mind to confirm?
(In reply to Roman Joost from comment #1) > Thanks for your report. > > Looks like there is a mistake in the hostrequires paramater. You can request > either by: > > --hostrequire '<system><numanodes ..></system' > > which is the recommended way or by: > > --hostrequire 'numa_node_count >= 2' > > which is deprecated but still works. > > Would you mind to confirm? Both way you mentioned are working: # bkr workflow-simple --hostrequire="<system><numanodes op='>=' value='2'/></system>" --debug --distro="RHEL-7.2-20151030.0" --task="/distribution/dummy" --prettyxml --arch="x86_64" <job retention_tag="Scratch"> <whiteboard></whiteboard> <recipeSet priority="Normal"> <recipe ks_meta="" whiteboard=""> <distroRequires> <and> <distro_name op="=" value="RHEL-7.2-20151030.0"/> <distro_arch op="=" value="x86_64"/> </and> </distroRequires> <hostRequires> <and> <system> <numanodes op=">=" value="2"/> </system> </and> </hostRequires> <repos/> <partitions/> <task name="/distribution/install" role="STANDALONE"> <params/> </task> <task name="/distribution/dummy" role="STANDALONE"> <params/> </task> </recipe> </recipeSet> </job> Submitted: ['J:1197584'] # bkr workflow-simple --hostrequire='numa_node_count >= 2' --debug --distro="RHEL-7.2-20151030.0" --task="/distribution/dummy" --prettyxml --arch="x86_64" <job retention_tag="Scratch"> <whiteboard></whiteboard> <recipeSet priority="Normal"> <recipe ks_meta="" whiteboard=""> <distroRequires> <and> <distro_name op="=" value="RHEL-7.2-20151030.0"/> <distro_arch op="=" value="x86_64"/> </and> </distroRequires> <hostRequires> <and> <numa_node_count op=">=" value="2"/> </and> </hostRequires> <repos/> <partitions/> <task name="/distribution/install" role="STANDALONE"> <params/> </task> <task name="/distribution/dummy" role="STANDALONE"> <params/> </task> </recipe> </recipeSet> </job> Submitted: ['J:1197586'] So the problem is --hostrequire="numanodes >= 2" used to work but not working now.
(In reply to Wayne Sun from comment #2) > So the problem is --hostrequire="numanodes >= 2" used to work but not > working now. Are you sure that has ever worked? What Beaker versions did you see it work/stop working? Maybe you were using it and by coincidence it was giving you machines with more than 1 NUMA node even though the filter was having no effect? We introduced the <numanodes/> filter, which must be enclosed in <system/>, in Beaker 0.10.1: https://git.beaker-project.org/cgit/beaker/commit/?id=12cb295834a207629862b88efa53f0b342a07abe Prior to that the only supported filter was <numa_node_count/>.
(In reply to Dan Callaghan from comment #3) > (In reply to Wayne Sun from comment #2) > > So the problem is --hostrequire="numanodes >= 2" used to work but not > > working now. > > Are you sure that has ever worked? What Beaker versions did you see it > work/stop working? > > Maybe you were using it and by coincidence it was giving you machines with > more than 1 NUMA node even though the filter was having no effect? > > We introduced the <numanodes/> filter, which must be enclosed in <system/>, > in Beaker 0.10.1: > > https://git.beaker-project.org/cgit/beaker/commit/ > ?id=12cb295834a207629862b88efa53f0b342a07abe > > Prior to that the only supported filter was <numa_node_count/>. Ok, got it. Thanks for clarify this, I think this could be closed as NOTABUG now.