Bug 1300326 - fedpkg unused-patches chokes on non-ascii characters
Summary: fedpkg unused-patches chokes on non-ascii characters
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: fedpkg
Version: 23
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dennis Gilmore
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-01-20 13:38 UTC by Mattias Ellert
Modified: 2016-09-13 11:49 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-09-13 11:49:15 UTC
Type: Bug

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Mattias Ellert 2016-01-20 13:38:43 UTC 
Description of problem:
fedpkg unused-patches chokes on non-ascii characters.

Version-Release number of selected component (if applicable):
fedpkg-1.20-2.fc23.noarch

How reproducible:
Always

Steps to Reproduce:
1. "fedpkg unused-patches" for a package with a non-ascii character in specfile.

Actual results:
$ fedpkg unused-patches 
Could not execute unused_patches: 'ascii' codec can't decode byte 0xc3 in position 18473: ordinal not in range(128)

Expected results:
No error due to non-ascii characters.

Additional info:
Comment 1 cqi 2016-08-23 10:33:25 UTC 
Hi, could you try again with latest version fedpkg-1.23-1.fc24? Additionally, what are unicode characters there, and what is the character encoding set in terminal?

I tried to reproduce in following steps

1. make changes to SPEC file by adding a changelog item with Chinese characters
2. create a dummy patch file
3. fedpkg unused-patches

All in UTF-8, and it works well.
Comment 2 Mattias Ellert 2016-09-13 11:49:15 UTC 
Sorry for the delay.
I confirm that fedpkg-1.25-1.fc24 works.
Note You need to log in before you can comment on or make changes to this bug.