Bug 1300603 - ld reports .eh_frame_hdr TABLE overlaps while testing whether relocation are not truncated
Summary: ld reports .eh_frame_hdr TABLE overlaps while testing whether relocation are ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: binutils
Version: 7.3
Hardware: aarch64
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Nick Clifton
QA Contact: Miloš Prchlík
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-01-21 09:28 UTC by Miloš Prchlík
Modified: 2018-02-08 10:08 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: When an application is linked, it is possible for it to contain duplicate blocks of information describing how to unwind the stack. (Called FDE or Frame Description Entry) Consequence: These duplicates, although not harmful, would cause the linker to emit error messages about overlaps in the .eh_frame_hdr table. Fix: Add code to the linker to detect and ignore duplicate FDE entries. Result: No more spurious error messages from the linker.
Clone Of:
Environment:
Last Closed: 2018-02-08 07:35:20 UTC
Target Upstream Version:

Attachments (Terms of Use)
Ignore duplicate FDE entries (796 bytes, patch)
2016-02-10 14:09 UTC, Nick Clifton 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Comment 1 Nick Clifton 2016-02-09 17:20:30 UTC 
This appears to have been fixed upstream:

  https://sourceware.org/bugzilla/show_bug.cgi?id=17467

testing now...
Comment 2 Nick Clifton 2016-02-09 17:44:30 UTC 
Nope - that patch has already been applied to the sources.  Back to the drawing board...
Comment 3 Nick Clifton 2016-02-10 14:09:56 UTC 
Created attachment 1122796 [details]
Ignore duplicate FDE entries

This patch will solve the problem.

Well maybe solve is not quite the correct word.  The problem is not that there
are overlapping FDE entries, but rather there are *duplicate* FDE entries.  The
patch works around this by just suppressing the overlap warning for the duplicates but really the correct solution would be to eliminate them altogether.  This requires a more extensive change and one that I do not feel comfortable doing without more discussion on the binutils mailing list.

The reason that this problem has come up now is that the code to check for overlapping FDE entries was not present in earlier binutils releases.
Comment 4 Nick Clifton 2016-04-13 14:00:26 UTC 
Patch applied.
Comment 5 John Feeney 2018-01-26 17:08:27 UTC 
I am trying to clean up old AArch64 bugzillas and came across this.

What can we do to get this VERIFIED and CLOSED? 

Thanks.
Comment 6 Miloš Prchlík 2018-01-29 08:05:59 UTC 
My guess is the bug, while fixed, fell under the table and wasn't added to the 7.3 erratum :( I'm not really sure what process we should follow now, I'm open to suggestions - the issue is gone, either fixed by the patch in the case of 7.3 (test runs for 7.3 builds, binutils-2.25.1-*, are clear), or by rebases in 7.4, 7.5 and Alt.
Comment 7 Martin Cermak 2018-01-31 12:08:03 UTC 
I think it's late to add this to a released erratum.  Milos, please, indicate the bug is fixed by flipping to VERIFIED (+ filling in the fixed in field) and the, if noone objects, we can close this one out.

Matt, does, the above plan sound good to you?
Comment 10 Miloš Prchlík 2018-02-08 07:34:09 UTC 
The bug was uncovered by a regression test for another bug, and AFAICT it's been fixed correctly (comment #4) as the corresponding test passed several test runs following the problematic one. Despite not being a part of the erratum, I believe it's been verified.
Comment 11 Miloš Prchlík 2018-02-08 07:35:20 UTC 
And closing, as it's too late to change erratum that's been already shipped in RHEL-7.3 days.
Comment 12 Martin Cermak 2018-02-08 10:08:05 UTC 
Thanks, Milos.
Note You need to log in before you can comment on or make changes to this bug.