Bug 1302204 - Review Request: perl-Importer - Alternative interface to modules that export symbols
Review Request: perl-Importer - Alternative interface to modules that export ...
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jitka Plesnikova
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2016-01-27 02:06 EST by Petr Pisar
Modified: 2016-01-27 08:42 EST (History)
2 users (show)

See Also:
Fixed In Version: perl-Importer-0.012-1.fc24
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-01-27 08:42:24 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
jplesnik: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Petr Pisar 2016-01-27 02:06:44 EST
Spec URL: https://ppisar.fedorapeople.org/perl-Importer/perl-Importer.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Importer/perl-Importer-0.012-1.fc24.src.rpm
Description:
This Perl module acts as a layer between Exporter and modules which consume
exports. It is feature-compatible with Exporter, plus some much needed
extras. You can use this to import symbols from any exporter that follows
Exporters specification. The exporter modules themselves do not need to use
or inherit from the Exporter module, they just need to set @EXPORT and/or
other variables.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2016-01-27 04:58:16 EST
Source file is ok
Summary is ok
License is ok
Description is ok
URL is ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Importer-0.012-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.22.1)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Importer-0.012-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(Importer) = 0.012
      1 perl-Importer = 0.012-1.fc24
Binary provides are Ok.

$ rpmlint /perl-Importer*
perl-Importer.src: W: invalid-url Source0: http://www.cpan.org/modules/by-module/Importer/Importer-0.012.tar.gz HTTP Error 404: Not Found
./perl-Importer.spec: W: invalid-url Source0: http://www.cpan.org/modules/by-module/Importer/Importer-0.012.tar.gz HTTP Error 404: Not Found
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint does not contain any error, only warning.

FIX: Invalid Source0 link. It has to be updated.


Please correct 'FIX' issue.

Otherwise package is good.
Approved
Comment 2 Gwyn Ciesla 2016-01-27 08:26:18 EST
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Importer
Comment 3 Petr Pisar 2016-01-27 08:42:24 EST
I fixed the Source0 URL.

Thank you for the review and the repository.

Note You need to log in before you can comment on or make changes to this bug.