Red Hat Bugzilla – Bug 1303402
[DOCS] [3.2] Document the Jenkins Image as a S2I Builder
Last modified: 2017-03-08 13:14 EST
In OSE 3.2, Jenkins image is S2I compatible. The user can create custom Jenkins images tailored to their use cases. Jenkins configuration and plugins can be injected via an S2I build step.
Dev for this feature is:
Trello card is:
QA for this feature is:
Using Images in the S2I section:
Upstream docs in the form of a PR (currently):
PR merged 2016-03-03, with ‘to_followup’ label. Plan for this BZ:
- Improve style to normal docs standards.
- Translate JSON block to YAML.
Commit pushed to master at https://github.com/openshift/openshift-docs
Merge pull request #1725 from tnguyen-rh/bz1303402
Bug 1303402, Update style of "Using Jenkins as a Source-To-Image builder"; s/JSON/YAML/
This was mistakenly moved to RELEASE_PENDING w/o going through ON_QA.
Moving to ON_QA.
XiuJuan, how do the docs (after PR 1725) look to you?
Add two insignificant comments in your PR, could you have a look?
Others look good to me.
(In reply to XiuJuan Wang from comment #6)
XiuJuan, thanks for the quick response.
> Add two insignificant comments in your PR, could you have a look?
This is a good catch:
Here is the PR that fixes it:
For the record, in asciidoc the correct syntax for such constructs is basically two square-brace pairs surrounding a valid "local anchor" identifier. In this case the error was actually at the end of the line, where was only one closing-square-brace. (See PR 1735.)
I believe the other comment (regarding the xref) is a legitimate misunderstanding. In comment #3, i posted links to the commit and the PR, and not to a properly-rendered preview of the doc set, where the xref does resolve correctly.
> Others look good to me.
Cool. Moving status to RELEASE_PENDING.
https://access.redhat.com/documentation/en/openshift-enterprise/3.2/using-images/chapter-5-other-images (section 5.2.6)