Bug 1304739 - ModuleOptions parsing can't handle EAP7 configuration
Summary: ModuleOptions parsing can't handle EAP7 configuration
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Operations Network
Classification: JBoss
Component: Plugin -- JBoss EAP 7
Version: JON 3.3.5
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: DR01
: One-off release
Assignee: Michael Burman
QA Contact: Sunil Kondkar
URL:
Whiteboard:
: 1314303 1320289 (view as bug list)
Depends On:
Blocks: 1314853
TreeView+ depends on / blocked
 
Reported: 2016-02-04 13:53 UTC by Michael Burman
Modified: 2019-06-24 15:03 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-06 18:56:42 UTC
Type: Bug

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1320289 0 medium CLOSED Exception when trying to edit Module options from Security subsystem 2021-02-22 00:41:40 UTC

Internal Links: 1320289

Description Michael Burman 2016-02-04 13:53:41 UTC 
Description of problem: ModuleOptions component assumes structure of the module options attribute include an index number that can be used to match attribute states. These are not necessarily present in the EAP7 configuration.

EAP6:

subsystem=security,security-domain=RHQDSSecurityDomainNoTx,authentication=classic,login-modules:0,module-option

In EAP7 there are examples such as jaspitest which doesn't have the index number that is expected:

subsystem=security,security-domain=jaspitest,authentication=jaspi,login-module-stack,module-options

This causes a NumberFormatException since the AS7 module can't handle this sort of scenario. Other security-domains include the necessary :0/:1 etc so they can be parsed correctly.

Version-Release number of selected component (if applicable): RHQ master, EAP7 ER04


How reproducible: Always


Steps to Reproduce:
1. Install EAP7
2. Start monitoring
3. Watch agent.log

Actual results:


Expected results:


Additional info:
Comment 1 Michael Burman 2016-02-10 10:56:15 UTC 
ModuleOptionsComponent.loadResourceConfiguration lines 347 and 316 at least with input strings failing such as "curity", "ult,subsystem=security,security-domain=jaspitest,authentication=jaspi,login-module-stack" and "ult"
Comment 2 Heiko W. Rupp 2016-03-03 13:38:41 UTC 
*** Bug 1314303 has been marked as a duplicate of this bug. ***
Comment 3 Michael Burman 2016-03-04 16:28:23 UTC 
Fixed in master:

commit f0d02edd1706df08e0d49813a38a3371b9cea33e
Author: Michael Burman <miburman>
Date:   Fri Mar 4 18:26:38 2016 +0200

    [BZ 1304739] Check for NumberFormatException when parsing security-module config
Comment 6 Sunil Kondkar 2016-03-23 14:38:00 UTC 
Verified on JON 3.3 EAP plugin pack Update 04 DR01

Installed and imported EAP7. Verified that agent log does not display NumberFormatException.
Comment 8 Filip Brychta 2019-06-24 15:03:40 UTC 
*** Bug 1320289 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.