Bug 1305835 - Remove nasty rpmmacro redefine
Summary: Remove nasty rpmmacro redefine
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: sed
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Petr Stodulka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-02-09 11:28 UTC by Ondrej Vasik
Modified: 2016-02-09 12:44 UTC (History)
4 users (show)

Fixed In Version: sed-4.2.2-15.fc24
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-02-09 12:44:05 UTC
Type: Bug


Attachments (Terms of Use)

Description Ondrej Vasik 2016-02-09 11:28:04 UTC
Description of problem:
sed.spec redefines system macro _bindir to /bin . This is not something spec file should usually do. I would prefer to simplify the spec, remove the redefine and ship sed normally in /usr/bin/sed .

Current solution is confusing for anyone who parses the spec files.

How reproducible:
always


Steps to Reproduce:
1. Check rpm -ql sed ... listed as /bin/sed - as specfile redefines _bindir

Actual results:
listed as /bin/sed - as specfile redefines _bindir

Expected results:
listed as /usr/bin/sed
(please make sure sed provides /bin/sed later on - as there may be file dependencies)

Additional info: Nasty hack introduced by http://pkgs.fedoraproject.org/cgit/rpms/sed.git/commit/?id=dc295e904f97e72c96ac98038b42aab39f5fb501

Comment 1 Ondrej Vasik 2016-02-09 11:29:20 UTC
(as a sidenote, this construction was maybe completely valid in 2004, in times of RHL 7.1, but should not be part of current Fedora.)

Comment 2 Petr Stodulka 2016-02-09 12:20:18 UTC
Yes, it was discussed during December but I have forgotten it.

Comment 3 Petr Stodulka 2016-02-09 12:44:05 UTC
Macro is removed + added provides of /bin/sed for packages which require this binary directly.


Note You need to log in before you can comment on or make changes to this bug.