RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1307098 - yum downloadonly does not reliably remove lock files
Summary: yum downloadonly does not reliably remove lock files
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: yum
Version: 6.7
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: rc
: 6.8
Assignee: Valentina Mukhamedzhanova
QA Contact: Eva Mrakova
URL:
Whiteboard:
Depends On:
Blocks: 1269194 1277547 1337912
TreeView+ depends on / blocked
 
Reported: 2016-02-12 17:16 UTC by Andy Grimm
Modified: 2019-11-14 07:26 UTC (History)
6 users (show)

Fixed In Version: yum-3.2.29-74.el6
Doc Type: Bug Fix
Doc Text:
Previously, a /var/run/yum.pid file was left on the disk after running the "yum --downloadonly" command. Consequently, under certain circumstances, the "yum" command failed because the yum utility incorrectly assumed that another instance of "yum" was already running. With this update, /var/run/yum.pid is correctly removed after running "yum --downloadonly", and the described problem no longer occurs.
Clone Of:
: 1337912 (view as bug list)
Environment:
Last Closed: 2017-03-21 11:00:55 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:0702 0 normal SHIPPED_LIVE yum bug fix update 2017-03-21 12:39:57 UTC

Description Andy Grimm 2016-02-12 17:16:17 UTC
Description of problem:
When "/usr/bin/yum -y --downloadonly update" is called, and there are packages to download, the process almost always leaves behind /var/run/yum.pid and rpmdb lockfiles.

The reason for this appears to be that yum calls sys.exit in this scenario, and sys.exit does not reliably trigger the __del__ method for the YumBase object, which is where all the unlocking/cleanup happen.

Relevant code from upstream, where this problem likely still exists:

sys,exit happens here:
http://yum.baseurl.org/gitweb?p=yum.git;a=blob;f=yum/__init__.py;h=84bea3eba2cf464f29666affb80ce658fc8fc074;hb=HEAD#l2627

__del__ method is here:
http://yum.baseurl.org/gitweb?p=yum.git;a=blob;f=yum/__init__.py;h=84bea3eba2cf464f29666affb80ce658fc8fc074;hb=HEAD#l235

Version-Release number of selected component (if applicable):
yum-3.2.29-69.el6.noarch

How reproducible:
Almost always

Steps to Reproduce:
1.  Log into a system for which there will be updates to download
2.  /usr/bin/yum -y --downloadonly update
3.  ls /var/run/yum.pid /var/lib/rpm/__*

Actual results:
yum.pid and rpmdb lockfiles are present


Expected results:
lock files should be removed prior to the yum process exiting.

Comment 2 Andy Grimm 2016-02-15 22:01:55 UTC
One update on this:  I realized that I may be wrong about the current function/purpose of the /var/lib/rpm/__db* files.  I was under the impression that those were lock files that would block subsequent transactions, but that does not seem to be the case in further tests.  Also, it seems that while calling self.closeRpmDB() does close those filehandles, it doesn't actually remove the files.  

Adding self.doUnlock() prior to the sys.exit definitely works to remove the PID file, though.

Comment 3 Andy Grimm 2016-02-16 21:12:16 UTC
It looks like upstream code closes these database well before the exit.  It appears to have been added in this commit:

http://yum.baseurl.org/gitweb?p=yum.git;a=commitdiff;h=05666dc9295fb433d1b081068dbe74e535cfc228

Comment 14 errata-xmlrpc 2017-03-21 11:00:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0702.html


Note You need to log in before you can comment on or make changes to this bug.