Spec URL: https://sagitter.fedorapeople.org/qr_mumps/qr_mumps.spec SRPM URL: https://sagitter.fedorapeople.org/qr_mumps/qr_mumps-1.2-1.fc23.src.rpm Description: qr_mumps is a software package for the solution of sparse, linear systems on multicore computers. It implements a direct solution method based on the QR factorization of the input matrix. Therefore, it is suited to solving sparse least-squares problems and to computing the minimum-norm solution of sparse, underdetermined problems. It can obviously be used for solving square problems in which case the stability provided by the use of orthogonal transformations comes at the cost of a higher operation count with respect to solvers based on, e.g., the LU factorization. qr_mumps supports real and complex, single or double precision arithmetic. Fedora Account System Username: sagitter This package is for Fedora and EPEL7. It needs metis >= 5.1.0-12
* If this is only for Fedora and EPEL-7, why do you change __global_ldflags for 0%{rhel} < 7? * Is there a reason you are not passing %{?_smp_mflags} to make to allow parallel build? * Is there a reason to BuildRequire pkgconfig? I don't see it being used anywhere... * IMO the library symlinks should be relative. * Consider putting the variables repeated in both make calls into a macro. * Consider putting repeated parts of the gfortran calls into a macro. * Consider using a build conditional (http://www.rpm.org/wiki/PackagerDocs/ConditionalBuilds) for the conditional handling of docs. * Consider using install consistently (instead of cp -p, possibly also instead of mkdir -p). But these are mostly cosmetic, so I am going to approve this.
One more nitpick: Group tag is obsolete, even on RHEL/EPEL-7.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/gfortran, /usr/lib64/gfortran/modules [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/gfortran, /usr/lib64/gfortran/modules [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [?]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in qr_mumps-openmp , qr_mumps-openmp-devel , qr_mumps-doc , qr_mumps- debuginfo [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.2.14 starting (python version = 3.4.3)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata Mock Version: 1.2.14 INFO: Mock Version: 1.2.14 Finish: chroot init INFO: installing package(s): /home/dtardon/packaging/fedora/new/1309795-qr_mumps/results/qr_mumps-1.2-1.fc24.x86_64.rpm /home/dtardon/packaging/fedora/new/1309795-qr_mumps/results/qr_mumps-devel-1.2-1.fc24.x86_64.rpm /home/dtardon/packaging/fedora/new/1309795-qr_mumps/results/qr_mumps-openmp-1.2-1.fc24.x86_64.rpm /home/dtardon/packaging/fedora/new/1309795-qr_mumps/results/qr_mumps-openmp-devel-1.2-1.fc24.x86_64.rpm /home/dtardon/packaging/fedora/new/1309795-qr_mumps/results/qr_mumps-doc-1.2-1.fc24.noarch.rpm /home/dtardon/packaging/fedora/new/1309795-qr_mumps/results/qr_mumps-debuginfo-1.2-1.fc24.x86_64.rpm /home/dtardon/packaging/fedora/new/1309795-qr_mumps/results/qr_mumps-debuginfo-1.2-1.fc24.x86_64.rpm ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 24 --setopt=deltarpm=false install /home/dtardon/packaging/fedora/new/1309795-qr_mumps/results/qr_mumps-1.2-1.fc24.x86_64.rpm /home/dtardon/packaging/fedora/new/1309795-qr_mumps/results/qr_mumps-devel-1.2-1.fc24.x86_64.rpm /home/dtardon/packaging/fedora/new/1309795-qr_mumps/results/qr_mumps-openmp-1.2-1.fc24.x86_64.rpm /home/dtardon/packaging/fedora/new/1309795-qr_mumps/results/qr_mumps-openmp-devel-1.2-1.fc24.x86_64.rpm /home/dtardon/packaging/fedora/new/1309795-qr_mumps/results/qr_mumps-doc-1.2-1.fc24.noarch.rpm /home/dtardon/packaging/fedora/new/1309795-qr_mumps/results/qr_mumps-debuginfo-1.2-1.fc24.x86_64.rpm /home/dtardon/packaging/fedora/new/1309795-qr_mumps/results/qr_mumps-debuginfo-1.2-1.fc24.x86_64.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: qr_mumps-1.2-1.fc24.x86_64.rpm qr_mumps-devel-1.2-1.fc24.x86_64.rpm qr_mumps-openmp-1.2-1.fc24.x86_64.rpm qr_mumps-openmp-devel-1.2-1.fc24.x86_64.rpm qr_mumps-doc-1.2-1.fc24.noarch.rpm qr_mumps-debuginfo-1.2-1.fc24.x86_64.rpm qr_mumps-1.2-1.fc24.src.rpm qr_mumps.x86_64: W: spelling-error Summary(en_US) multithreaded -> multicolored qr_mumps.x86_64: W: spelling-error Summary(en_US) multifrontal -> multinational qr_mumps.x86_64: W: spelling-error %description -l en_US multicore -> multicolored qr_mumps.x86_64: W: spelling-error %description -l en_US underdetermined -> under determined, under-determined, undetermined qr_mumps-devel.x86_64: W: only-non-binary-in-usr-lib qr_mumps-devel.x86_64: W: no-documentation qr_mumps-openmp.x86_64: W: summary-not-capitalized C qr_mumps with OpenMP support qr_mumps-openmp-devel.x86_64: W: only-non-binary-in-usr-lib qr_mumps-openmp-devel.x86_64: W: no-documentation qr_mumps.src: W: spelling-error Summary(en_US) multithreaded -> multicolored qr_mumps.src: W: spelling-error Summary(en_US) multifrontal -> multinational qr_mumps.src: W: spelling-error %description -l en_US multicore -> multicolored qr_mumps.src: W: spelling-error %description -l en_US underdetermined -> under determined, under-determined, undetermined 7 packages and 0 specfiles checked; 0 errors, 13 warnings. Requires -------- qr_mumps-openmp (rpmlib, GLIBC filtered): /sbin/ldconfig gcc-gfortran(x86-64) ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgfortran.so.3()(64bit) libgfortran.so.3(GFORTRAN_1.0)(64bit) libgfortran.so.3(GFORTRAN_1.4)(64bit) libgomp.so.1()(64bit) libgomp.so.1(GOMP_1.0)(64bit) libgomp.so.1(GOMP_4.0)(64bit) libgomp.so.1(OMP_1.0)(64bit) libgomp.so.1(OMP_3.0)(64bit) libm.so.6()(64bit) libmetis.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) qr_mumps (rpmlib, GLIBC filtered): /sbin/ldconfig gcc-gfortran(x86-64) libc.so.6()(64bit) libgfortran.so.3()(64bit) libgfortran.so.3(GFORTRAN_1.0)(64bit) libgfortran.so.3(GFORTRAN_1.4)(64bit) libm.so.6()(64bit) libmetis.so.0()(64bit) rtld(GNU_HASH) qr_mumps-debuginfo (rpmlib, GLIBC filtered): qr_mumps-openmp-devel (rpmlib, GLIBC filtered): qr_mumps-openmp(x86-64) qr_mumps-doc (rpmlib, GLIBC filtered): qr_mumps-devel (rpmlib, GLIBC filtered): qr_mumps(x86-64) Provides -------- qr_mumps-openmp: libdqrmMP.so.1.2()(64bit) libqrmMP_common.so.1.2()(64bit) qr_mumps-openmp qr_mumps-openmp(x86-64) qr_mumps: libdqrm.so.1.2()(64bit) libqrm_common.so.1.2()(64bit) qr_mumps qr_mumps(x86-64) qr_mumps-debuginfo: qr_mumps-debuginfo qr_mumps-debuginfo(x86-64) qr_mumps-openmp-devel: qr_mumps-openmp-devel qr_mumps-openmp-devel(x86-64) qr_mumps-doc: qr_mumps-doc qr_mumps-devel: qr_mumps-devel qr_mumps-devel(x86-64) Source checksums ---------------- http://buttari.perso.enseeiht.fr/qr_mumps/releases/1.2/qr_mumps-1.2.tgz : CHECKSUM(SHA256) this package : 6aacdab63c4d4160998f47ac736d4665f0dd5deb6002eeb2aa59de6eb274c337 CHECKSUM(SHA256) upstream package : 6aacdab63c4d4160998f47ac736d4665f0dd5deb6002eeb2aa59de6eb274c337 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1309795 --mock-options=-r fedora-rawhide-x86_64 --no-clean --no-cleanup-after Buildroot used: fedora-23-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(In reply to David Tardon from comment #1) > * If this is only for Fedora and EPEL-7, why do you change __global_ldflags > for 0%{rhel} < 7? I'm going to package for EPEL6 too, even if it is not ready yet. > * Is there a reason you are not passing %{?_smp_mflags} to make to allow > parallel build? It's not supported or compiler fails easily. > * Is there a reason to BuildRequire pkgconfig? I don't see it being used > anywhere... Indeed, it's useless. > * IMO the library symlinks should be relative. > * Consider putting the variables repeated in both make calls into a macro. > * Consider putting repeated parts of the gfortran calls into a macro. > * Consider using a build conditional > (http://www.rpm.org/wiki/PackagerDocs/ConditionalBuilds) for the conditional > handling of docs. > * Consider using install consistently (instead of cp -p, possibly also > instead of mkdir -p). Thank you. Spec URL: https://sagitter.fedorapeople.org/qr_mumps/qr_mumps.spec SRPM URL: https://sagitter.fedorapeople.org/qr_mumps/qr_mumps-1.2-2.fc23.src.rpm
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/qr_mumps
qr_mumps-1.2-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0f30aedb60
qr_mumps-1.2-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0f30aedb60
qr_mumps-1.2-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.