Bug 1309872 - Use XDG_RUNTIME_DIR
Summary: Use XDG_RUNTIME_DIR
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: xpra
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jonathan Underwood
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1317304
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-02-18 20:58 UTC by Dennis Schridde
Modified: 2017-01-03 01:21 UTC (History)
2 users (show)

See Also:
Fixed In Version: xpra-1.0-2.fc25 xpra-1.0-2.fc24
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-01-02 19:50:04 UTC
Type: Bug


Attachments (Terms of Use)

Description Dennis Schridde 2016-02-18 20:58:08 UTC
Description of problem:
Fedora currently patches [^1] several of xpra's paths to point to /var/run/user/$UID/xpra. This is inconvenient, because that directory might not exist (e.g. in a minimal container, where xpra is not started from a shell) or the user might have different preferences. XDG_RUNTIME_DIR exists [^2], on my system points to that exact directory (but is configurable) and seems to exactly match this use-case:
```
$XDG_RUNTIME_DIR defines the base directory relative to which user-specific non-essential runtime files and other file objects (such as sockets, named pipes, ...) should be stored. The directory MUST be owned by the user, and he MUST be the only one having read and write access to it. Its Unix access mode MUST be 0700.
```

I suggest to replace the string "/var/run/user/$UID" with "$XDG_RUNTIME_DIR" to allow the user more control over these paths.

[^1]: https://pkgs.fedoraproject.org/cgit/rpms/xpra.git/tree/xpra-0.16.0-move-to-var-run.patch
[^2]: https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html

Version-Release number of selected component (if applicable):
0.16.1-2.fc24

Comment 1 Dennis Schridde 2016-02-18 20:59:41 UTC
See-Also: http://xpra.org/trac/ticket/1129 (upstream bug)

Comment 2 Jonathan Underwood 2016-02-19 09:10:09 UTC
OK, it seems this needs some thinking and discussion - for now on the upstream ticket. When we converge to the right solution, I'll update the Fedora package accordingly.

Comment 3 Jonathan Underwood 2016-02-19 10:08:03 UTC
OK, have just pushed a build (0.16.2-2) which should use XDG_RUNTIME_DIR for sockets and logs. This also reverts the change to the run script location - we're back to sticking it under ~/.xpra for now, so as not to break other clients (see upstream ticket).

http://koji.fedoraproject.org/koji/taskinfo?taskID=13046673

Comment 4 Fedora Update System 2016-02-19 13:43:34 UTC
xpra-0.16.2-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-241d30d0c5

Comment 5 Jonathan Underwood 2016-02-19 14:11:48 UTC
Oh dear, 0.16.2-2 is horribly broken.

Comment 6 Jonathan Underwood 2016-02-19 14:30:56 UTC
Pushed a build dropping patch to use XDG_RUNTIME_DIR for now, until I have time to work on this, so at least we have a working xpra in rawhide.

http://koji.fedoraproject.org/koji/taskinfo?taskID=13048811

Comment 7 Jonathan Underwood 2016-02-19 14:55:44 UTC
And now a package that actually has the icon files in the right place:

http://koji.fedoraproject.org/koji/taskinfo?taskID=13049047

Comment 8 Jan Kurik 2016-02-24 15:26:32 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

Comment 9 Jonathan Underwood 2016-03-24 17:43:53 UTC
One blocker for this is that using su -l to change to a different user doesn't create or set XDG_RUNTIME_DIR, and that's a common use case (i.e. switching to a different user to start an xpra server).

Comment 10 Fedora Update System 2016-12-10 14:43:45 UTC
xpra-1.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-186fb568a7

Comment 11 Fedora Update System 2016-12-10 14:44:00 UTC
xpra-1.0-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a06f2e6e03

Comment 12 Fedora Update System 2016-12-11 03:30:03 UTC
xpra-1.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-186fb568a7

Comment 13 Fedora Update System 2016-12-11 03:58:31 UTC
xpra-1.0-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a06f2e6e03

Comment 14 Fedora Update System 2017-01-02 19:50:04 UTC
xpra-1.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2017-01-03 01:21:06 UTC
xpra-1.0-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.