Red Hat Bugzilla – Bug 1309907
Review Request: yamllint - A linter for YAML files
Last modified: 2016-03-06 22:50:24 EST
Spec URL: https://maxamillion.fedorapeople.org/yamllint.spec SRPM URL: https://maxamillion.fedorapeople.org/yamllint-0.7.2-1.fc24.src.rpm Description: A linter for YAML files. yamllint does not only check for syntax validity, but for weirdnesses like key repetition and cosmetic problems such as lines length, trailing spaces, indentation, etc. Fedora Account System Username: maxamillion
Scratch build in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=13040533
maxamillion's scratch build of yamllint-0.7.2-1.fc24.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13040533
maxamillion's scratch build of yamllint-0.7.2-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13040604
> yamllint.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/yamllint/cli.py 644 /usr/bin/env Will fix upstream.
> yamllint.noarch: W: no-manual-page-for-binary yamllint Also could you package the man page? It's available by running: make -C docs man
the docs dir isn't included in the tarball from pypi. $ wget -c https://pypi.python.org/packages/source/y/yamllint/yamllint-0.7.2.tar.gz#md5=12903e44f70b0ddbbb1747daf69ee2e1 --2016-02-24 11:38:47-- https://pypi.python.org/packages/source/y/yamllint/yamllint-0.7.2.tar.gz Resolving pypi.python.org (pypi.python.org)... 199.27.79.223 Connecting to pypi.python.org (pypi.python.org)|199.27.79.223|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 29830 (29K) [application/octet-stream] Saving to: ‘yamllint-0.7.2.tar.gz’ yamllint-0.7.2.tar.gz 100%[================================================>] 29.13K --.-KB/s in 0.001s 2016-02-24 11:38:47 (25.1 MB/s) - ‘yamllint-0.7.2.tar.gz’ saved [29830/29830] $ tar -zxvf yamllint-0.7.2.tar.gz yamllint-0.7.2/ yamllint-0.7.2/setup.cfg yamllint-0.7.2/PKG-INFO yamllint-0.7.2/setup.py yamllint-0.7.2/README.rst yamllint-0.7.2/yamllint.egg-info/ yamllint-0.7.2/yamllint.egg-info/top_level.txt yamllint-0.7.2/yamllint.egg-info/requires.txt yamllint-0.7.2/yamllint.egg-info/entry_points.txt yamllint-0.7.2/yamllint.egg-info/dependency_links.txt yamllint-0.7.2/yamllint.egg-info/SOURCES.txt yamllint-0.7.2/yamllint.egg-info/PKG-INFO yamllint-0.7.2/yamllint/ yamllint-0.7.2/yamllint/parser.py yamllint-0.7.2/yamllint/linter.py yamllint-0.7.2/yamllint/config.py yamllint-0.7.2/yamllint/cli.py yamllint-0.7.2/yamllint/__init__.py yamllint-0.7.2/yamllint/rules/ yamllint-0.7.2/yamllint/rules/trailing_spaces.py yamllint-0.7.2/yamllint/rules/new_lines.py yamllint-0.7.2/yamllint/rules/new_line_at_end_of_file.py yamllint-0.7.2/yamllint/rules/line_length.py yamllint-0.7.2/yamllint/rules/key_duplicates.py yamllint-0.7.2/yamllint/rules/indentation.py yamllint-0.7.2/yamllint/rules/hyphens.py yamllint-0.7.2/yamllint/rules/empty_lines.py yamllint-0.7.2/yamllint/rules/document_start.py yamllint-0.7.2/yamllint/rules/document_end.py yamllint-0.7.2/yamllint/rules/common.py yamllint-0.7.2/yamllint/rules/comments_indentation.py yamllint-0.7.2/yamllint/rules/comments.py yamllint-0.7.2/yamllint/rules/commas.py yamllint-0.7.2/yamllint/rules/colons.py yamllint-0.7.2/yamllint/rules/brackets.py yamllint-0.7.2/yamllint/rules/braces.py yamllint-0.7.2/yamllint/rules/__init__.py yamllint-0.7.2/yamllint/conf/ yamllint-0.7.2/yamllint/conf/default.yml yamllint-0.7.2/tests/ yamllint-0.7.2/tests/test_syntax_errors.py yamllint-0.7.2/tests/test_spec_examples.py yamllint-0.7.2/tests/test_parser.py yamllint-0.7.2/tests/test_config.py yamllint-0.7.2/tests/common.py yamllint-0.7.2/tests/__init__.py yamllint-0.7.2/tests/rules/ yamllint-0.7.2/tests/rules/test_trailing_spaces.py yamllint-0.7.2/tests/rules/test_new_lines.py yamllint-0.7.2/tests/rules/test_new_line_at_end_of_file.py yamllint-0.7.2/tests/rules/test_line_length.py yamllint-0.7.2/tests/rules/test_key_duplicates.py yamllint-0.7.2/tests/rules/test_indentation.py yamllint-0.7.2/tests/rules/test_hyphens.py yamllint-0.7.2/tests/rules/test_empty_lines.py yamllint-0.7.2/tests/rules/test_document_start.py yamllint-0.7.2/tests/rules/test_document_end.py yamllint-0.7.2/tests/rules/test_common.py yamllint-0.7.2/tests/rules/test_comments_indentation.py yamllint-0.7.2/tests/rules/test_comments.py yamllint-0.7.2/tests/rules/test_commas.py yamllint-0.7.2/tests/rules/test_colons.py yamllint-0.7.2/tests/rules/test_brackets.py yamllint-0.7.2/tests/rules/test_braces.py yamllint-0.7.2/tests/rules/__init__.py $ ls -l yamllint-0.7.2/ total 16 -rw-rw-r--. 1 admiller admiller 1004 Feb 5 08:12 PKG-INFO -rw-rw-r--. 1 admiller admiller 1422 Feb 5 08:11 README.rst -rw-rw-r--. 1 admiller admiller 59 Feb 5 08:12 setup.cfg -rw-rw-r--. 1 admiller admiller 1916 Feb 5 08:11 setup.py drwxrwxr-x. 3 admiller admiller 180 Feb 5 08:12 tests drwxrwxr-x. 4 admiller admiller 180 Feb 5 08:12 yamllint drwxrwxr-x. 2 admiller admiller 160 Feb 5 08:12 yamllint.egg-info
Thanks for reporting this. Please try version 1.0.2, it should fix the problem.
maxamillion's scratch build of yamllint-1.0.2-1.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13121565
Spec URL: https://maxamillion.fedorapeople.org/yamllint.spec SRPM URL: https://maxamillion.fedorapeople.org/yamllint-1.0.3-1.fc24.src.rpm
For an unknown reason, the man page is executable: could you fix this? > yamllint.noarch: W: spurious-executable-perm /usr/share/man/man1/yamllint.1.gz Apart from that I don't see any other problem.
Yup, I completely flaked on the mode for the install line for the man page. Thanks for the catch. Spec URL: https://maxamillion.fedorapeople.org/yamllint.spec SRPM URL: https://maxamillion.fedorapeople.org/yamllint-1.0.3-2.fc24.src.rpm
Congratulations :) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated". 3 files have unknown license. Detailed output of licensecheck in /tmp/1309907-yamllint/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: yamllint-1.0.3-2.fc22.noarch.rpm yamllint-1.0.3-2.fc22.src.rpm yamllint.noarch: W: spelling-error Summary(en_US) linter -> liner, liter, inter yamllint.noarch: W: spelling-error %description -l en_US linter -> liner, liter, inter yamllint.noarch: W: spelling-error %description -l en_US weirdnesses -> weirdness's, weirdness es, weirdness-es yamllint.src: W: spelling-error Summary(en_US) linter -> liner, liter, inter yamllint.src: W: spelling-error %description -l en_US linter -> liner, liter, inter yamllint.src: W: spelling-error %description -l en_US weirdnesses -> weirdness's, weirdness es, weirdness-es 2 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- yamllint.noarch: W: spelling-error Summary(en_US) linter -> liner, liter, inter yamllint.noarch: W: spelling-error %description -l en_US linter -> liner, liter, inter yamllint.noarch: W: spelling-error %description -l en_US weirdnesses -> weirdness's, weirdness es, weirdness-es 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Requires -------- yamllint (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3-PyYAML Provides -------- yamllint: yamllint Source checksums ---------------- https://pypi.python.org/packages/source/y/yamllint/yamllint-1.0.3.tar.gz : CHECKSUM(SHA256) this package : 0f6c2226cd09913b7ccc99c7956f4472712dd435dab87fe68cd3627eae39a84f CHECKSUM(SHA256) upstream package : 0f6c2226cd09913b7ccc99c7956f4472712dd435dab87fe68cd3627eae39a84f Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1309907 Buildroot used: fedora-22-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/yamllint
yamllint-1.0.3-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ff94abba3a
yamllint-1.0.3-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ff94abba3a
yamllint-1.0.3-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.