Bug 1310550 - [kde-l10n] Please add Supplements tag in specfile
Summary: [kde-l10n] Please add Supplements tag in specfile
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: kde-l10n
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Than Ngo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1314406
TreeView+ depends on / blocked
 
Reported: 2016-02-22 08:29 UTC by Parag Nemade
Modified: 2016-03-23 12:02 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-03-23 11:59:49 UTC
Type: Bug


Attachments (Terms of Use)
Add Supplements for langpacks namimg guidelines (28.47 KB, application/mbox)
2016-02-22 08:29 UTC, Parag Nemade
no flags Details

Description Parag Nemade 2016-02-22 08:29:16 UTC
Created attachment 1129181 [details]
Add Supplements for langpacks namimg guidelines

Description of problem:
As per newly approved https://fedoraproject.org/wiki/PackagingDrafts/Langpack guidelines in https://fedorahosted.org/fpc/ticket/593#comment:18 , I would like to request to please commit the attached patch so that langpacks installation will be helpful.

Comment 1 Rex Dieter 2016-02-23 17:42:20 UTC
I didn't realize Rich dependencies were sanctioned yet, I assume this is a f24+ only change?

Any objection to my conditionally wrapping things like:

%if 0%{?fedora} > 23
Supplements: (%{name} = %{version}-%{release} and langpacks-ar)
%endif

??

Comment 2 Rex Dieter 2016-02-23 20:10:22 UTC
speaking with tibbs, we're pretty sure it should be safe for f23+ at least, and we're not going to be backporting this version of f22 (most likely), so should be safe as-is

Comment 3 Parag Nemade 2016-02-24 05:47:06 UTC
Rex, Thanks for your help in committing required changes.

Comment 4 Rex Dieter 2016-03-23 11:58:30 UTC
Looking at this closer, I wonder why you want rich-deps here at all, why is this simpler:

Supplements: langpacks-foo

not sufficient?

Comment 5 Rex Dieter 2016-03-23 11:59:49 UTC
Ah, nevermind, we don't want this pulled in unconditionally, that's why.

That said, I think we could consider making the conditional on something better than kde-l10n... I'll think more on it.

Comment 6 Parag Nemade 2016-03-23 12:02:17 UTC
Thank you for understanding the use here for langpacks functionality. Like calligra-l10n, if needed conditionals can be added here as well.


Note You need to log in before you can comment on or make changes to this bug.