Bug 1310894 - gnome-terminal hyperlink detection broken in xml
Summary: gnome-terminal hyperlink detection broken in xml
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-terminal
Version: 23
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1310892
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-02-22 22:44 UTC by Christopher Tubbs
Modified: 2016-12-20 18:56 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of: 1310892
Environment:
Last Closed: 2016-12-20 18:56:54 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Christopher Tubbs 2016-02-22 22:44:28 UTC
+++ This bug was initially created as a clone of Bug #1310892 +++

Description of problem:
When I Ctrl-click a link in gnome-terminal, it opens in the default browser. However, if the link is in an XML tag, the first character of the closing tag "<" is always included in the hyperlink when it is highlighted (underlined) and clicked.

Version-Release number of selected component (if applicable):
gnome-terminal-3.18.2-1.fc23.x86_64 (affects every version of RHEL/CentOS/Fedora I've tried, but this is what's on my current system)

How reproducible:
100%

Steps to Reproduce:
1. Paste: "<url>https://bugzilla.redhat.com</url>" into gnome-terminal
2. Ctrl+click on the link

Actual results:
Browser tries to open "https://bugzilla.redhat.com<"

Expected results:
Browser should open "https://bugzilla.redhat.com"

Additional info:

This bug has been irritating me for many RHEL and Fedora releases.

While angle brackets can be used to delimit a URI (http://www.ietf.org/rfc/rfc3986.txt), it's generally unsafe to use without urlencoding (http://www.blooberry.com/indexdot/html/topics/urlencoding.htm), so it should never be seen as part of the URL itself.

Even if it were seen in a valid URL, I think the use-case of Ctrl+clicking from XML is a much more reasonable use case to support, because it is much more likely users will want to click on URLs inside XML than to click on a URL that actually happens to have a less-than sign in it.

Further, even if it were expected behavior to include the less-than character as part of the URL, the very next characters ('/url>' in my example) would also be valid, but are clearly not included in the URL... so clearly, this is a bug.

Comment 1 Christopher Tubbs 2016-02-22 22:45:57 UTC
Interesting to note that bugzilla's own hyperlink detection is working perfectly.

Comment 2 Egmont Koblinger 2016-02-23 00:33:37 UTC
There are many more problems with URL detection. Upstream fix is at https://bugzilla.gnome.org/show_bug.cgi?id=756038. No easy way and no simple patch to backport to old branches exists.

Comment 3 Egmont Koblinger 2016-03-04 20:06:15 UTC
I've backported the fix to the 3-18 branch (and hopefully applies cleanly to older ones as well):
https://git.gnome.org/browse/gnome-terminal/commit/?h=gnome-3-18&id=3bd692f

Comment 4 Fedora End Of Life 2016-11-24 15:42:29 UTC
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Fedora End Of Life 2016-12-20 18:56:54 UTC
Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.