Created attachment 1129878 [details] enable rpmdev-packager to check git configuration Description of problem: I would find it useful if the rpmdev-packager script check the git configuration for my username and email address. How reproducible: `git config user.name` and `git config user.email` contain all the necessary information for rpmdev-packager. Additional info: Patch attached.
Created attachment 1130006 [details] enable rpmdev-packager to check git configuration Whoops, forgot to wrap the email with < and >.
Yep, I noticed and fixed that and did some other modifications in https://git.fedorahosted.org/cgit/rpmdevtools.git/commit/?id=769a09866ccacafa36b656caab07600f51ced722 In particular, I moved git to after .fedora.cert, because I guesstimate it's more likely for the git identity than the certificate one to be not the packager one.
rpmdevtools-8.7-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e11971c7e9
rpmdevtools-8.7-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9a18dce7e1
rpmdevtools-8.7-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9a18dce7e1
rpmdevtools-8.7-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e11971c7e9
rpmdevtools-8.8-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e11971c7e9
rpmdevtools-8.8-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9a18dce7e1
rpmdevtools-8.9-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e11971c7e9
rpmdevtools-8.9-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9a18dce7e1
rpmdevtools-8.9-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
rpmdevtools-8.9-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
This isn't working right. Moving the git configuration check after the packager certificates check revealed a bug in the latter that results in the git configuration not being used at all. The fifth field of the passwd file can be used for more than just a name. For example, if you use the chfn utility, it prompts you for the name, office, office phone, and home phone. Even if you only set the name with that tool, it results in multiple commas in the $fullname as parsed by this script, such as: John Doe,,,, Given that plus an existing ~/.fedora.cert file, $packager is set to: John Doe,,,, <john.doe> Then the script never makes it to the git configuration check. I'm not sure what the best course of action would be to correct this. Improve the parsing of $fullname? Move the git check back in front of the certificates check?
The issue looks completely unrelated to the git configuration check, so a separate bug report would have been preferable instead of reopening this... and due to the same reason, the root issue needs a real fix, not changing the order of the checks. That's done now in https://git.fedorahosted.org/cgit/rpmdevtools.git/commit/?id=b67dfbf0d1b88dbc722daf22ee27b18eb6244639
That's fair, sorry I didn't think of it like that initially. I'll open a new BZ.