Hide Forgot
Description of problem: In order to make the config more clearly, suggest to add "filter_hostname" to filter host by hostname. and add "filter_host_hwuuid" to filter host by hwuuid. Version-Release number of selected component (if applicable): virt-who-0.16-4.el6.noarch How reproducible: Always Steps to Reproduce: 1. Set "filter_host_uuids=XXXX and hypervisor_id=hostname" in etc/virt-who.d/XXX can filter host by hostname. 2. Set "filter_host_uuids=XXXX and hypervisor_id=hwuuid" in etc/virt-who.d/XXX can filter host by hwuuid. Actual results: "filter_host_uuids" can specify hosts which uuid (or hostname or hwuuid, based on hypervisor_id) is specified in comma-separated list in this option will be reported. Expected results: In order to increase config file's readability, I suggest to add "filter_hostname" and "filter_host_hwuuid" as the following: 1. Suggest to set "filter_hostname=XXX and hypervisor_id=hostname" in /etc/virt-who.d/XXX to filter host by hostname. 2.Suggest to set "filter_hwuuid=XXX and hypervisor_id=hwuuid" to filter host by hwuuid. Additional info:
It's too late for 6.8, lets move it to 6.9.
I don't think this change will make things more clear. Adding two more options would only cause more confusion (four actually, there is also exclude_host_uuids). We've already documented the behaviour in the manual page: filter_host_uuids: Only hosts which uuid (or hostname or hwuuid, based on hypervisor_id) is specified in comma-separated list in this option will be reported. Put the value into the double-quotes if it contains special characters (like comma). We could rename this option to something like `filter_hosts` or `filter_host_by_id`, but I'm not sure it worth the effort. Opinions?
Radek, I agree with you to modify "filter_host_uuids" to "filter_hosts", it should be more clear for customer. Thanks.
The option is renamed upstream, the old variant (filter_host_uuids) is still there for backwards compatibility. Same applies to exclude_ variant (exclude_host_uuids -> exclude_hosts). https://github.com/virt-who/virt-who/commit/a2770ef638a5b7350f02902fa2a82e22a3e7d2cf