Bug 1312101 - Don't allow submission of container-build without commits pushed to remote repo
Summary: Don't allow submission of container-build without commits pushed to remote repo
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: rpkg
Version: 23
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dennis Gilmore
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-02-25 17:57 UTC by Pavol Babinčák
Modified: 2016-03-14 10:04 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-03-14 10:04:09 UTC
Type: Bug

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Pavol Babinčák 2016-02-25 17:57:59 UTC 
Description of problem:
*rpkg normally doesn't allow people to submit non-scratch (rpm) builds without having commits already pushed to remove server.

container-build seems to allow that.


See error which was caused by this on server side: https://github.com/release-engineering/koji-containerbuild/issues/18
Comment 1 Ales Raszka 2016-03-02 14:11:10 UTC 
Pull-request: https://pagure.io/rpkg/pull-request/35
Comment 2 Lubomír Sedlář 2016-03-02 15:03:44 UTC 
Interesting thing is that the check is already there and should have prevented the build from being submitted:

https://pagure.io/rpkg/blob/master/f/src/pyrpkg/__init__.py#_2463-2464

What versions of of rhpkg and pyrpkg were used to get that error? Huemin, could you please post output of

    rpm -q rhpkg pyrpkg
Comment 3 hchen 2016-03-02 15:12:15 UTC 
I don't have the environment any more. My laptop just got upgraded from RHEL 6 CSB to RHEL 7.
Comment 4 Lubomír Sedlář 2016-03-03 08:59:27 UTC 
Thanks, RHEL 6 CSB is enough information, as it turns out the fixed version of rpkg was not built yet.
Note You need to log in before you can comment on or make changes to this bug.