Bug 1313317 - [Improvement] postgres logfiles to have timestamps
Summary: [Improvement] postgres logfiles to have timestamps
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Installer
Version: 6.1.6
Hardware: All
OS: Linux
medium
medium vote
Target Milestone: Unspecified
Assignee: Chris Roberts
QA Contact: Katello QA List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-01 11:38 UTC by Pavel Moravec
Modified: 2019-11-14 07:31 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-09-07 15:33:18 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Pavel Moravec 2016-03-01 11:38:41 UTC
Description of problem:
It would be great if psql logfiles under /var/lib/pgsql/data/pg_log/ directory have timestamps. Since without that, it is hard to correlate an event / error in psql with other logs.

See:

http://www.postgresql.org/docs/9.0/static/runtime-config-logging.html#GUC-LOG-LINE-PREFIX

how to achieve that.


Version-Release number of selected component (if applicable):
Sat6.1.7


How reproducible:
100%


Steps to Reproduce:
1. Install and start Sat6, do whatever you want
2. check logs in /var/lib/pgsql/data/pg_log/ dir


Actual results:
The logs are without timestamp.


Expected results:
The logs to be with timestamp.


Additional info:

Comment 2 Bryan Kearney 2016-07-26 15:25:24 UTC
Moving 6.2 bugs out to sat-backlog.

Comment 3 Bryan Kearney 2016-07-26 15:34:39 UTC
Moving 6.2 bugs out to sat-backlog.

Comment 5 Pavel Moravec 2016-08-05 06:21:49 UTC
This seems to be fixed due to some side-effect bugfix/improvement. Since I see:

# head /var/lib/pgsql/data/pg_log/postgresql-Thu.log -n2
2016-08-04 13:37:36 CEST ERROR:  duplicate key value violates unique constraint "dynflow_coordinator_records_pkey"
2016-08-04 13:37:36 CEST DETAIL:  Key (id, class)=(delayed-executor, Dynflow::Coordinator::DelayedExecutorLock) already exists.
#

and:

# grep -r log_line_prefix /usr/share/foreman-installer/
/usr/share/foreman-installer/modules/postgresql/manifests/globals.pp:  $log_line_prefix          = undef,
/usr/share/foreman-installer/modules/postgresql/manifests/params.pp:  $log_line_prefix            = '%t '
/usr/share/foreman-installer/modules/postgresql/manifests/server/config.pp:  $log_line_prefix            = $postgresql::server::log_line_prefix
/usr/share/foreman-installer/modules/postgresql/manifests/server/config.pp:  if $log_line_prefix {
/usr/share/foreman-installer/modules/postgresql/manifests/server/config.pp:    postgresql::server::config_entry {'log_line_prefix':
/usr/share/foreman-installer/modules/postgresql/manifests/server/config.pp:      value => $log_line_prefix,
/usr/share/foreman-installer/modules/postgresql/manifests/server.pp:  $log_line_prefix            = $postgresql::params::log_line_prefix,
#

So from my point of view, the BZ can be closed as fixed in 6.2.

Do you agree, Chris/Toledo?

Comment 6 Chris Roberts 2016-09-07 15:33:18 UTC
Hi Pavel,

I agree with the fix in 6.2 I will close this one.

pmoravec++

- Chris Roberts


Note You need to log in before you can comment on or make changes to this bug.