Bug 1314797 - org.libvirt.Domain constants with package only access despite use in public API
Summary: org.libvirt.Domain constants with package only access despite use in public API
Keywords:
Status: NEW
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libvirt-java
Version: unspecified
Hardware: All
OS: All
unspecified
low
Target Milestone: ---
Assignee: Libvirt Maintainers
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-04 14:16 UTC by bugzilla.redhat.com.3632
Modified: 2016-04-03 20:32 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description bugzilla.redhat.com.3632 2016-03-04 14:16:40 UTC 
Domain->createDomainXML call takes CreateFlags as second argument but these flag definitions are defined as package only in Domain class. Please make them public. TY.
Comment 1 bugzilla.redhat.com.3632 2016-03-04 14:21:25 UTC 
See

http://libvirt.org/git/?p=libvirt-java.git;a=blob;f=src/main/java/org/libvirt/Domain.java;h=ee26a95fa468c115777c8dacd8754eb447071fc5;hb=5d84874d99ee399276873fb52625303ec3a3f396#l33

and

http://libvirt.org/git/?p=libvirt-java.git;a=blob;f=src/main/java/org/libvirt/Connect.java;h=b3e29be75d1f77200c983dbbba0c77a0f8b4083e;hb=5d84874d99ee399276873fb52625303ec3a3f396#l284
Comment 2 bugzilla.redhat.com.3632 2016-03-04 14:22:23 UTC 
Ah sorry, it's Connect->domainCreateXML.
Comment 3 Cole Robinson 2016-03-23 20:14:28 UTC 
CCing Claudio Bley who is the libvirt-java maintainer
Comment 4 bugzilla.redhat.com.3632 2016-03-24 11:28:14 UTC 
Might also be a good idea to use enums for those constants such that Java IDE's can find them automatically and suggest them to the user.
Comment 5 claudio.bley 2016-04-03 20:32:28 UTC 
Yes, this has been a thorn in my side for quite some time. And yes, I want to use Enums. (https://www.redhat.com/archives/libvir-list/2014-March/msg01436.html)

I'll see that I get something together during the next week.
Note You need to log in before you can comment on or make changes to this bug.