Spec URL:https://sopotc.fedorapeople.org/eclipse-epp-logging/eclipse-epp-logging.spec SRPM URL: https://sopotc.fedorapeople.org/eclipse-epp-logging/eclipse-epp-logging-1.100.0-0.1.gitc6ce9f2.fc23.src.rpm Description: EPP Logging provides a set of logging plugins for the Eclipse IDE. Fedora Account System Username:sopotc
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation IGNORE - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: Cannot find license.html in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text Please, ask to upstream to include license/s file/s - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation IGNORE ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "EPL-1.0", "Unknown or generated". 29 files have unknown license. Detailed output of licensecheck in /home/gil/1318363-eclipse- epp-logging/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/eclipse/droplets [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/eclipse/droplets, /usr/share/eclipse [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: eclipse-epp-logging-1.100.0-0.1.gitc6ce9f2.fc25.noarch.rpm eclipse-epp-logging-1.100.0-0.1.gitc6ce9f2.fc25.src.rpm eclipse-epp-logging.noarch: W: no-documentation eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/net.sf.cglib.core_3.1.0.jar ../../../../../java/cglib.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.apache.httpcomponents.fluent-hc_4.5.2.jar ../../../../../java/httpcomponents/fluent-hc.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.apache.lucene.core_3.6.2.jar ../../../../../java/lucene3/lucene-core-3.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.objectweb.asm.tree_5.0.4.jar ../../../../../java/objectweb-asm/asm-tree.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.objectweb.asm_5.0.4.jar ../../../../../java/objectweb-asm/asm.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.easymock_3.3.1.jar ../../../../../java/easymock3.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.hamcrest.text_1.3.0.v20090501071000.jar ../../../../../java/hamcrest/text.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.apache.commons.io_2.4.0.jar ../../../../../java/apache-commons-io.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.apache.commons.lang3_3.4.0.jar ../../../../../java/apache-commons-lang3.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.hamcrest.integration_1.3.0.v20090501071000.jar ../../../../../java/hamcrest/integration.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.objectweb.asm.analysis_5.0.4.jar ../../../../../java/objectweb-asm/asm-analysis.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.hamcrest.library_1.3.0.v20090501071000.jar ../../../../../java/hamcrest/library.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.objectweb.asm.util_5.0.4.jar ../../../../../java/objectweb-asm/asm-util.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.junit_4.12.0.jar ../../../../../java/junit.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/com.google.gson_2.3.1.jar ../../../../../java/google-gson/gson.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.mockito.mockito-core_1.10.19.jar ../../../../../java/mockito/mockito-core.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.hamcrest.core_1.3.0.v201303031735.jar ../../../../../java/hamcrest/core.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/com.google.guava_18.0.0.jar ../../../../../java/guava.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.objenesis_2.1.0.jar ../../../../../java/objenesis/objenesis.jar eclipse-epp-logging.src:12: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 12) 2 packages and 0 specfiles checked; 0 errors, 21 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory eclipse-epp-logging.noarch: W: no-documentation eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.hamcrest.text_1.3.0.v20090501071000.jar ../../../../../java/hamcrest/text.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.hamcrest.library_1.3.0.v20090501071000.jar ../../../../../java/hamcrest/library.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.junit_4.12.0.jar ../../../../../java/junit.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.objectweb.asm.util_5.0.4.jar ../../../../../java/objectweb-asm/asm-util.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/net.sf.cglib.core_3.1.0.jar ../../../../../java/cglib.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.apache.commons.io_2.4.0.jar ../../../../../java/apache-commons-io.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.apache.httpcomponents.fluent-hc_4.5.2.jar ../../../../../java/httpcomponents/fluent-hc.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/com.google.gson_2.3.1.jar ../../../../../java/google-gson/gson.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.objectweb.asm_5.0.4.jar ../../../../../java/objectweb-asm/asm.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.easymock_3.3.1.jar ../../../../../java/easymock3.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.apache.commons.lang3_3.4.0.jar ../../../../../java/apache-commons-lang3.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.objectweb.asm.tree_5.0.4.jar ../../../../../java/objectweb-asm/asm-tree.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.mockito.mockito-core_1.10.19.jar ../../../../../java/mockito/mockito-core.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/com.google.guava_18.0.0.jar ../../../../../java/guava.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.apache.lucene.core_3.6.2.jar ../../../../../java/lucene3/lucene-core-3.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.objenesis_2.1.0.jar ../../../../../java/objenesis/objenesis.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.hamcrest.core_1.3.0.v201303031735.jar ../../../../../java/hamcrest/core.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.hamcrest.integration_1.3.0.v20090501071000.jar ../../../../../java/hamcrest/integration.jar eclipse-epp-logging.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/epp-logging/eclipse/plugins/org.objectweb.asm.analysis_5.0.4.jar ../../../../../java/objectweb-asm/asm-analysis.jar 1 packages and 0 specfiles checked; 0 errors, 20 warnings. Requires -------- eclipse-epp-logging (rpmlib, GLIBC filtered): eclipse-platform java-headless javapackages-tools osgi(com.google.gson) osgi(com.google.guava) osgi(org.apache.commons.io) osgi(org.apache.commons.lang3) osgi(org.apache.httpcomponents.fluent-hc) osgi(org.apache.lucene.core) osgi(org.eclipse.emf.databinding) osgi(org.eclipse.jdt.annotation) osgi(org.eclipse.mylyn.commons.notifications.core) osgi(org.eclipse.mylyn.commons.notifications.ui) osgi(org.eclipse.mylyn.commons.ui) osgi(org.eclipse.mylyn.commons.workbench) Provides -------- eclipse-epp-logging: eclipse-epp-logging mvn(org.eclipse.epp.logging:aeri.ide.bundle) mvn(org.eclipse.epp.logging:aeri.ide.feature) mvn(org.eclipse.epp.logging:aeri.rcp.bundle) mvn(org.eclipse.epp.logging:aeri.rcp.feature) mvn(org.eclipse.epp.logging:aeri.rcp.silent.bundle) mvn(org.eclipse.epp.logging:aeri.rcp.silent.feature) mvn(org.eclipse.epp.logging:bundles:pom:) mvn(org.eclipse.epp.logging:examples:pom:) mvn(org.eclipse.epp.logging:features:pom:) mvn(org.eclipse.epp.logging:org.eclipse.epp.logging.aeri.core) mvn(org.eclipse.epp.logging:org.eclipse.epp.logging.aeri.feature) mvn(org.eclipse.epp.logging:org.eclipse.epp.logging.aeri.ide) mvn(org.eclipse.epp.logging:org.eclipse.epp.logging.sdk.feature) mvn(org.eclipse.epp.logging:org.eclipse.epp.logging:pom:) osgi(aeri.ide.bundle) osgi(aeri.ide.feature) osgi(aeri.rcp.bundle) osgi(aeri.rcp.feature) osgi(aeri.rcp.silent.bundle) osgi(aeri.rcp.silent.feature) osgi(org.eclipse.epp.logging.aeri.core) osgi(org.eclipse.epp.logging.aeri.feature) osgi(org.eclipse.epp.logging.aeri.ide) osgi(org.eclipse.epp.logging.sdk.feature) Source checksums ---------------- http://git.eclipse.org/c/epp/org.eclipse.epp.logging.git/snapshot/org.eclipse.epp.logging-c6ce9f27af44ffd8a28e1153140a61a7d15d3f32.tar.xz : CHECKSUM(SHA256) this package : 04eed1ce0da1647d78d660c07463a0359bc0de351197e7acd0f18db0655a29fa CHECKSUM(SHA256) upstream package : 04eed1ce0da1647d78d660c07463a0359bc0de351197e7acd0f18db0655a29fa Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1318363 --plugins Java -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: Cannot find license.html in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text Please, ask to upstream to include license/s file/s Please, ask to upstream to include license headers in the following files: ./examples/aeri.ide.bundle/src/aeri/ide/DemoServerConnection.java ./examples/aeri.rcp.bundle/src/aeri/rcp/DemoNotificationSupport.java ./examples/aeri.rcp.bundle/src/aeri/rcp/DemoServerConnection.java ./examples/aeri.rcp.bundle/src/aeri/rcp/LogEvent.java ./examples/aeri.rcp.bundle/src/aeri/rcp/handlers/NotifyConfigureSystemHandler.java ./examples/aeri.rcp.bundle/src/aeri/rcp/handlers/NotifyLogEventHandler.java ./examples/aeri.rcp.bundle/src/aeri/rcp/handlers/NotifyServerResponseHandler.java ./examples/aeri.rcp.silent.bundle/src/aeri/rcp/silent/ConsoleLogServerConnection.java ./tests/org.eclipse.epp.logging.aeri.core.tests/src/org/eclipse/epp/logging/aeri/core/filters/AcceptFreezeFilterTest.java ./tests/org.eclipse.epp.logging.aeri.core.tests/src/org/eclipse/epp/logging/aeri/core/filters/AcceptedPackagesFilterTest.java ./tests/org.eclipse.epp.logging.aeri.core.tests/src/org/eclipse/epp/logging/aeri/core/filters/AcceptedPluginsFilterTest.java ./tests/org.eclipse.epp.logging.aeri.core.tests/src/org/eclipse/epp/logging/aeri/core/filters/AcceptedProductsFilterTest.java ./tests/org.eclipse.epp.logging.aeri.core.tests/src/org/eclipse/epp/logging/aeri/core/filters/NoErrorStatusFilterTest.java ./tests/org.eclipse.epp.logging.aeri.core.tests/src/org/eclipse/epp/logging/aeri/core/filters/StatusIgnorePatternFilterTest.java https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification ./tests/org.eclipse.epp.logging.aeri.ide.tests/src/org/eclipse/epp/internal/logging/aeri/ide/actions/ConstantBehaviorCx.java ./tests/org.eclipse.epp.logging.aeri.ide.tests/src/org/eclipse/epp/internal/logging/aeri/ide/actions/DemoEndpoint.java ./tests/org.eclipse.epp.logging.aeri.ide.tests/src/org/eclipse/epp/internal/logging/aeri/ide/notifications/SetupNewServersNotificationTest.java ./tests/org.eclipse.epp.logging.aeri.ide.tests/src/org/eclipse/epp/internal/logging/aeri/ide/server/mars/ErrorAnalyserMessageParserTest.java ./tests/org.eclipse.epp.logging.aeri.ide.tests/src/org/eclipse/epp/internal/logging/aeri/ide/server/mars/IoTest.java ./tests/org.eclipse.epp.logging.aeri.ide.tests/src/org/eclipse/epp/internal/logging/aeri/ide/server/mars/LocalReportsHistoryTest.java ./tests/org.eclipse.epp.logging.aeri.ide.tests/src/org/eclipse/epp/internal/logging/aeri/ide/server/mars/RemoteProblemsHistoryTest.java ./tests/org.eclipse.epp.logging.aeri.ide.tests/src/org/eclipse/epp/internal/logging/aeri/ide/server/mars/ServerConnectionTest.java ./tests/org.eclipse.epp.logging.aeri.ide.tests/src/org/eclipse/epp/internal/logging/aeri/ide/server/mars/StatusesFingerprintTest.java ./tests/org.eclipse.epp.logging.aeri.tests/src/org/eclipse/epp/logging/aeri/tests/util/TestStatus.java ./tests/org.eclipse.epp.logging.aeri.tests/src/org/eclipse/epp/logging/aeri/tests/util/TestStatuses.java
Spec URL:https://sopotc.fedorapeople.org/eclipse-epp-logging/eclipse-epp-logging.spec SRPM URL: https://sopotc.fedorapeople.org/eclipse-epp-logging/eclipse-epp-logging-1.100.0-0.2.gitc6ce9f2.fc23.src.rpm I filed an upstream bug regarding the missing license headers https://bugs.eclipse.org/bugs/show_bug.cgi?id=489926 . I am not building or shipping neither the tests or the examples artifacts. Is it ok to leave them in the tarball for now? Once upstream updates them, I'll make sure to update the tarball. About the "Cannot find license.html in rpm(s)" - the license text is generated by the "eclipse-license" package and is included at build-time in each feature. This is why no license text is included in the git repo. So for example, it is included in the binary rpms here: /usr/share/eclipse/droplets/epp-logging/eclipse/features/org.eclipse.epp.logging.aeri.feature_*/license.html .
(In reply to Sopot Cela from comment #3) > Spec > URL:https://sopotc.fedorapeople.org/eclipse-epp-logging/eclipse-epp-logging. > spec > SRPM URL: > https://sopotc.fedorapeople.org/eclipse-epp-logging/eclipse-epp-logging-1. > 100.0-0.2.gitc6ce9f2.fc23.src.rpm > > I filed an upstream bug regarding the missing license headers > https://bugs.eclipse.org/bugs/show_bug.cgi?id=489926 . I am not building or > shipping neither the tests or the examples artifacts. Is it ok to leave them > in the tarball for now? Once upstream updates them, I'll make sure to update > the tarball. Ok. thanks > About the "Cannot find license.html in rpm(s)" - the license text is > generated by the "eclipse-license" package and is included at build-time in > each feature. This is why no license text is included in the git repo. So > for example, it is included in the binary rpms here: > /usr/share/eclipse/droplets/epp-logging/eclipse/features/org.eclipse.epp. > logging.aeri.feature_*/license.html . For me (and also by the guideline), license file text or hntml format should be included by upstream and not generated by other system tools Please, report to upstream the problem
FWIW, Licenses for eclipse projects are always done that way and as this is knowingly automated way of putting proper files in proper places I don't see the issue. It doesnt' differ from "automake --add-missing" installing COPYING file in your dir even in the case where you just forgot adding COPYING file yourself - aka you have to opt out. The eclipse-license way is at least opt-in solution where one intentionally adds a marker to get all the needed license files in place. Much like having a script doing smth like `wget URL1, URL2...; cp URL1..N ...". This shouldn't block the review in my eyes.
The point of the guideline is to ensure the package remains in compliance with the terms of license (some licenses require a copy of the license text to be installed). The binary RPMs of this package actually do install a copy of the full text of the license, even though the source tarball does not contain it. If you really want to, you can add this to the %files section: %license %{_datadir}/eclipse/droplets/epp-logging/eclipse/features/org.eclipse.epp.logging.aeri.feature_*/*.html But I agree with Alex, this shouldn't block the review since this would not alter the contents of the RPMs.
Spec URL:https://sopotc.fedorapeople.org/eclipse-epp-logging/eclipse-epp-logging.spec SRPM URL: https://sopotc.fedorapeople.org/eclipse-epp-logging/eclipse-epp-logging-1.100.0-0.3.gitc6ce9f2.fc23.src.rpm Updated SPEC and SRPM to accommodate Mat's hint. Spec file now contains a %license statement.
Sorry for delay. Approved
Thanks Gil for taking the time with the review. Repo was created and the package was pushed with http://pkgs.fedoraproject.org/cgit/rpms/eclipse-epp-logging.git/commit/?id=8c2070eaa37aefa2fe66779d5301305de1238a77 Rawhide koji build was also fired and completed successfully.
eclipse-epp-logging-1.100.0-0.3.gitc6ce9f2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-11c759b632
eclipse-epp-logging-1.100.0-0.3.gitc6ce9f2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-11c759b632
eclipse-epp-logging-1.100.0-0.4.gitc6ce9f2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-11c759b632
eclipse-epp-logging-1.100.0-0.5.gitc6ce9f2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-11c759b632
eclipse-epp-logging-1.100.0-0.5.gitc6ce9f2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.