Spec URL: https://sagitter.fedorapeople.org/gtengine/GTEngine.spec SRPM URL: https://sagitter.fedorapeople.org/gtengine/GTEngine-2.3-1.fc23.src.rpm Description: A library of source code for computing in the fields of mathematics, graphics, image analysis, and physics. The engine is written in C++ 11 and, as such, has portable access to standard constructs for multithreading programming on cores. The engine also supports high-performance computing using general purpose GPU programming (GPGPU). SIMD code is also available using Intel Streaming SIMD Extensions (SSE). This is new version of Wild Magic 5 Engine. Fedora Account System Username: sagitter This package is for Fedora only.
Name should be gtengine [https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming]. %description should be wrapped to 80 columns.
Spec URL: https://sagitter.fedorapeople.org/gtengine/gtengine.spec SRPM URL: https://sagitter.fedorapeople.org/gtengine/gtengine-2.3-2.fc23.src.rpm
rm -rf $RPMBUILDROOT is unnecessary. Hm, what is the "touch $RPM_BUILD_ROOT%{_libdir}/libgtengine.so.2" for? ln -sf %{_libdir}/libgtengine.so.2.0 $RPM_BUILD_ROOT%{_libdir}/libgtengine.so.2 ... I think this should be ln -s libgtengine.so.2.0 ${buildroot}%{_libdir}/libgtengine.so.2 ln -s libgtengine.so.2 ${buildroot}%{_libdir}/libgtengine.so (Links should be relative.) + license is acceptable (Boost) + license file is present, %license is used + name is OK + latest version + scriptlets look sane + provides/requires look fine + fedora-review has nothing interesting to say + devel subpackage is split out correctly rpmlint: gtengine.i686: W: spelling-error %description -l en_US multithreading -> multitasking gtengine.i686: W: no-documentation gtengine.src: W: spelling-error %description -l en_US multithreading -> multitasking gtengine-devel.i686: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 4 warnings. All OK. So the only thing is the strange installation commands.
Hm, does the license which forbids the distribution of the PDFs also apply to the installation instructions? It's only 5 pages and is included in the tarball, but strict reading of the notice suggests that it does: "The PDF documents at our site are copyrighted but not subject to the liberal terms of the Boost License".
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > rm -rf $RPMBUILDROOT is unnecessary. > > Hm, what is the "touch $RPM_BUILD_ROOT%{_libdir}/libgtengine.so.2" for? > > ln -sf %{_libdir}/libgtengine.so.2.0 > $RPM_BUILD_ROOT%{_libdir}/libgtengine.so.2 I didn't knew that was enough the link only. > ... > I think this should be > ln -s libgtengine.so.2.0 ${buildroot}%{_libdir}/libgtengine.so.2 > ln -s libgtengine.so.2 ${buildroot}%{_libdir}/libgtengine.so > Spec URL: https://sagitter.fedorapeople.org/gtengine/gtengine.spec SRPM URL: https://sagitter.fedorapeople.org/gtengine/gtengine-2.3-3.fc23.src.rpm > Hm, does the license which forbids the distribution of the PDFs also apply to > the installation instructions? It's only 5 pages and is included in the > tarball, but strict reading of the notice suggests that it does: > "The PDF documents at our site are copyrighted but not subject to the liberal > terms of the Boost License". I think that Installation PDF is not useful for packaging. Real documentation is online: http://www.geometrictools.com/Documentation/Documentation.html
> I think that Installation PDF is not useful for packaging. Yes, I don't think it should be put in the binary RPM. The problem is different: *if* the PDF is non-distributable, it has to be removed from the tarball in the SRPM. So the question is whether the PDF is under the boost license like the rest of the tarball, of it is under the license for documentation pdfs. Maybe you could query upstream?
Upstream maintainer replies me right now: "That PDF is a simple description for installation and release notes. There are no licensing issues for it. I intentionally did NOT include a copyright notice in the PDF, so it may be freely copied and redistributed without any restrictions."
The links are still wrong (they *must* be relative): ln -sf %{_libdir}/libgtengine.so.2.0 $RPM_BUILD_ROOT%{_libdir}/libgtengine.so.2 ln -sf %{_libdir}/libgtengine.so.2.0 $RPM_BUILD_ROOT%{_libdir}/libgtengine.so ↓ ln -sf libgtengine.so.2.0 $RPM_BUILD_ROOT%{_libdir}/libgtengine.so.2 ln -sf libgtengine.so.2.0 $RPM_BUILD_ROOT%{_libdir}/libgtengine.so Summary could be changed to: Summary: Library for computations in mathematics, graphics, image analysis, and physics Package is APPROVED.
Spec URL: https://sagitter.fedorapeople.org/gtengine/gtengine.spec SRPM URL: https://sagitter.fedorapeople.org/gtengine/gtengine-2.3-3.fc23.src.rpm Thank you. I kept same release number.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/gtengine
gtengine-2.3-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0007fb788b
gtengine-2.3-4.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-07dddc7cb8
gtengine-2.3-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0007fb788b
gtengine-2.3-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-07dddc7cb8
gtengine-2.3-4.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
gtengine-2.3-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.