Bug 1318703 - [rhevm-cli] update vmpool --prestarted_vms missing option
Summary: [rhevm-cli] update vmpool --prestarted_vms missing option
Keywords:
Status: CLOSED EOL
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: RestAPI
Version: 3.6.3.3
Hardware: Unspecified
OS: Unspecified
low
medium vote
Target Milestone: ---
: ---
Assignee: Marek Libra
QA Contact: sefi litmanovich
URL:
Whiteboard:
Depends On: 1343099
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-17 14:27 UTC by Ilanit Stein
Modified: 2022-03-16 08:49 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-29 11:15:40 UTC
oVirt Team: Virt


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHV-45310 0 None None None 2022-03-16 08:49:04 UTC
oVirt gerrit 58977 0 master MERGED restapi: VmPool properties list reviewed in RSDL 2016-06-10 14:00:21 UTC
oVirt gerrit 58999 0 ovirt-engine-3.6 MERGED restapi: VmPool properties list reviewed in RSDL 2016-06-13 12:25:54 UTC
oVirt gerrit 59003 0 ovirt-engine-4.0 MERGED restapi: VmPool properties list reviewed in RSDL 2016-06-12 21:44:13 UTC

Description Ilanit Stein 2016-03-17 14:27:46 UTC
Description of problem:
In the RSDL metadata, parameter "prestarted_vms" is missing.

Version-Release number of selected component (if applicable):
rhevm-3.6.3-5

How reproducible:
100%

Steps to Reproduce:
Use CLI command to update a VMpool: 
update vmpool <vmpool guid> --cluster-id 'd4cbf4c0-a190-4800-a300-eee73bd13f3d' --id '<vmpool guid>' --prestarted_vms 2 --template-id '<template guid>' --correlation_id 'vmpools_update_7b463408-2db2-4eb3'

Comment 1 Juan Hernández 2016-03-23 15:00:54 UTC
This happens because the "prestarted_vms" is not documented in the RSDL metadata file. As a result it isn't available in the Python SDK and in the CLI. Once this is fixed in the server side the Python SDK will need to be regenerated. The CLI won't need any change.

Comment 2 Sandro Bonazzola 2016-05-02 09:59:10 UTC
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.

Comment 3 Yaniv Lavi 2016-05-23 13:15:57 UTC
oVirt 4.0 beta has been released, moving to RC milestone.

Comment 4 Yaniv Lavi 2016-05-23 13:19:48 UTC
oVirt 4.0 beta has been released, moving to RC milestone.

Comment 5 Marek Libra 2016-05-30 08:00:26 UTC
The code seems to be already there for 4.0

Comment 6 Marek Libra 2016-06-09 14:16:15 UTC
missing properties will be added to the 3.6 SDK

Comment 7 Red Hat Bugzilla Rules Engine 2016-06-09 14:16:20 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 8 Marek Libra 2016-06-13 12:35:57 UTC
SDK needs to be regenerated

Comment 9 Shira Maximov 2016-07-12 10:53:07 UTC
try to verify on : RHEVM 3.6.8
can't verify yet, because the code isn't available yet.

Comment 10 Michal Skrivanek 2016-07-12 11:11:50 UTC
code is in 3.6.8-2 build

Comment 11 Michal Skrivanek 2016-07-12 11:26:40 UTC
Code is fixed in RSDL
Juan, do you need a separate bug to build the SDK?

Comment 12 Juan Hernández 2016-07-12 11:37:15 UTC
Michal, no need for a new bug, this change has been applied to the Python SDK when it was regenerated for version 3.6.8 of the engine:

  https://github.com/oVirt/ovirt-engine-sdk/commit/7afb48b929c50cb114cea6bdb7ac6a4bafcc62b3

  https://github.com/oVirt/ovirt-engine-sdk/blob/3.6.8.0/ovirt-engine-sdk-python.spec.in#L46

In order to verify make sure you have version 3.6.8.0 of the Python SDK installed, then the CLI should work correctly.

Comment 13 sefi litmanovich 2016-07-14 12:51:21 UTC
I can verify that adding a new vmpool with prestarted works now, and that rsdl is correct, versions:
rhevm-cli-3.6.2.1-1.el6ev.noarch
rhevm-3.6.8-0.1.el6.noarch
rhevm-sdk-python-3.6.8.0-1.el6ev.noarch

Couldn't verify with update cmd due to another bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1356607

I think we can verify this bug as the fix regarding prestarted_vms is working fine, but maybe need to re open in case you find out that the new bug has occurred for some reason as a result of this patch.

Comment 14 Marek Libra 2016-07-14 16:07:11 UTC
I agree in scope of this bug.
The #1356607 is most likely not connected with this change.


Note You need to log in before you can comment on or make changes to this bug.