Bug 1319924 - nightly livemedia-creator live images have slightly incorrect ISO names
Summary: nightly livemedia-creator live images have slightly incorrect ISO names
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: pungi
Version: 25
Hardware: All
OS: All
unspecified
medium
Target Milestone: ---
Assignee: Lubomír Sedlář
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-21 20:33 UTC by Adam Williamson
Modified: 2017-03-15 01:13 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-03-15 01:13:48 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Adam Williamson 2016-03-21 20:33:51 UTC
See F24 nightly composes. The productmd "compose ID" for a nightly compose is something like:

Fedora-24-20160321.n.0

the 'date(.type).respin' part of this is used in the names of, e.g., the anaconda ISOs:

Fedora-Server-netinst-x86_64-24-20160321.n.0.iso

however, it's not quite correct for livemedia-created live images:

Fedora-KDE-Live-x86_64-24-20160321.0.iso

note the type identifier - the ".n" - is missing.

the problem with this, aside from the lack of consistency, is that 'Fedora-24-20160321.0' would be a valid productmd compose ID, but for a *production* compose, not a nightly. There may even *be* a compose with the compose ID 'Fedora-24-20160321.0' (or whatever date / respin you like) which is not the same compose the image comes from.

We don't actually wind up with duplicated file names because the file names for production compose images appear to be based on the compose label rather than the compose ID (so we get Fedora-KDE-Live-x86_64-24_Alpha-5.iso or whatever). But it could still be confusing/misleading, particularly to tooling.

I would've tried to fix this, but I couldn't find the relevant Koji code for livemedia-creator, it doesn't appear to be in Koji git master. This does appear to be in Koji, not in pungi or pungi-fedora or livemedia-creator itself - the name is passed to livemedia-creator as "--iso-name", but it's not given to Koji by pungi, pungi only gives Koji the *first* part of the image name (Fedora-KDE-Live), Koji figures out the rest.

Comment 1 Dennis Gilmore 2016-03-21 21:10:06 UTC
reassigning to pungi, as it is whats sets the release variable

Comment 2 Jan Kurik 2016-07-26 04:13:04 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle.
Changing version to '25'.


Note You need to log in before you can comment on or make changes to this bug.