Bug 1320703 - 'fedpkg import $SRPM' fails
Summary: 'fedpkg import $SRPM' fails
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: fedpkg
Version: 23
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dennis Gilmore
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-23 18:43 UTC by Lokesh Mandvekar
Modified: 2016-09-05 06:55 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-23 08:29:53 UTC
Type: Bug


Attachments (Terms of Use)

Description Lokesh Mandvekar 2016-03-23 18:43:00 UTC
Description of problem:

Creating repo object from /home/lsm5/docker
Running: rpm -qp --nosignature --qf %{NAME} /home/lsm5/docker/SRPMS/docker-1.9.1-7.gitc6607d2.fc23.src.rpm
Running: rpm -qpl /home/lsm5/docker/SRPMS/docker-1.9.1-7.gitc6607d2.fc23.src.rpm
Status: 404 Not Found
Content-type: text/plain

Module "docker" does not exist!
Could not execute import_srpm: Error checking for docker-c6607d2.tar.gz at https://pkgs.fedoraproject.org/repo/pkgs/upload.cgi
Traceback (most recent call last):
  File "/usr/bin/fedpkg", line 16, in <module>
    main()
  File "/usr/lib/python2.7/site-packages/fedpkg/__main__.py", line 68, in main
    sys.exit(client.args.command())
  File "/usr/lib/python2.7/site-packages/pyrpkg/cli.py", line 1073, in import_srpm
    self.cmd.upload(uploadfiles, replace=True)
  File "/usr/lib/python2.7/site-packages/pyrpkg/__init__.py", line 2229, in upload
    self.lookasidecache.upload(self.module_name, f, file_hash)
  File "/usr/lib/python2.7/site-packages/pyrpkg/lookaside.py", line 250, in upload
    if self.remote_file_exists(name, filename, hash):
  File "/usr/lib/python2.7/site-packages/pyrpkg/lookaside.py", line 238, in remote_file_exists
    % (filename, self.upload_url))
pyrpkg.errors.UploadError: Error checking for docker-c6607d2.tar.gz at https://pkgs.fedoraproject.org/repo/pkgs/upload.cgi



Version-Release number of selected component (if applicable):
fedpkg-1.21-2.fc23.noarch
pyrpkg-1.36-1.fc23.noarch

How reproducible: consistent


Steps to Reproduce:
1. fedpkg import $SRPM

Actual results: see description


Expected results: source and tarballs should be imported


Additional info: saw this on rawhide first, but looks like it crept into f23 too.

Comment 1 Lokesh Mandvekar 2016-03-23 18:46:05 UTC
(In reply to Lokesh Mandvekar from comment #0)
> Description of problem:
> 
> Creating repo object from /home/lsm5/docker
> Running: rpm -qp --nosignature --qf %{NAME}
> /home/lsm5/docker/SRPMS/docker-1.9.1-7.gitc6607d2.fc23.src.rpm
> Running: rpm -qpl
> /home/lsm5/docker/SRPMS/docker-1.9.1-7.gitc6607d2.fc23.src.rpm
> Status: 404 Not Found
> Content-type: text/plain
> 
> Module "docker" does not exist!
> Could not execute import_srpm: Error checking for docker-c6607d2.tar.gz at
> https://pkgs.fedoraproject.org/repo/pkgs/upload.cgi
> Traceback (most recent call last):
>   File "/usr/bin/fedpkg", line 16, in <module>
>     main()
>   File "/usr/lib/python2.7/site-packages/fedpkg/__main__.py", line 68, in
> main
>     sys.exit(client.args.command())
>   File "/usr/lib/python2.7/site-packages/pyrpkg/cli.py", line 1073, in
> import_srpm
>     self.cmd.upload(uploadfiles, replace=True)
>   File "/usr/lib/python2.7/site-packages/pyrpkg/__init__.py", line 2229, in
> upload
>     self.lookasidecache.upload(self.module_name, f, file_hash)
>   File "/usr/lib/python2.7/site-packages/pyrpkg/lookaside.py", line 250, in
> upload
>     if self.remote_file_exists(name, filename, hash):
>   File "/usr/lib/python2.7/site-packages/pyrpkg/lookaside.py", line 238, in
> remote_file_exists
>     % (filename, self.upload_url))
> pyrpkg.errors.UploadError: Error checking for docker-c6607d2.tar.gz at
> https://pkgs.fedoraproject.org/repo/pkgs/upload.cgi
> 

btw, ^ is the output of 'fedpkg -v import SRPMS/docker-1.9.1-7.gitc6607d2.fc23.src.rpm'

Comment 2 Lokesh Mandvekar 2016-03-23 19:25:27 UTC
adding --module-name=rpms/docker after fedpkg took care of importing the source tarballs. Thanks to Nalin for pointing that out. Not sure if the 'docker' module needs to be added somewhere.

Comment 3 cqi 2016-08-23 08:29:53 UTC
It works for reporter.

Comment 4 Antonio Murdaca 2016-09-02 08:22:43 UTC
I'm experiencing this on F24 when trying to `fedpkg import` an F25 (docker) SRPM:

fedpkg-1.24-3.fc24.noarch
pyrpkg-1.46-1.fc24.noarch

$ fedpkg import /home/amurdaca/fedora-scm/docker/docker-1.12.1-9.git2649fe1.fc25.src.rpm
Could not execute import_srpm: Error checking for containerd-0ac3cd1.tar.gz at https://pkgs.fedoraproject.org/repo/pkgs/upload.cgi

When adding --module-name=rpms/docker to fedpkg everything works fine (as Lokesh did above)

Note that I'm able to fedpkg import on f23,f24 and rawhide just fine. This issue is happening only when import SRPM for f25.

Comment 5 Lubomír Sedlář 2016-09-05 06:55:32 UTC
Based on the error message it looks like the problem is checking if the tarball is already imported into lookaside cache. However, I can't seem to replicate the problem: verifying existence of the containerd tarball currently returns 'Available'.

Can you replicate this consistently? It could be a problem with namespacing: docker is both a namespace and a package name (i.e. rpms/docker), but it seems weird that it would sometimes work and sometimes fail.


Note You need to log in before you can comment on or make changes to this bug.