Bug 1321042 - Review Request: perl-RDF-Trine - RDF Framework for Perl
Summary: Review Request: perl-RDF-Trine - RDF Framework for Perl
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1318368 1318676 1318691 1318699
Blocks: 1349372
TreeView+ depends on / blocked
 
Reported: 2016-03-24 14:23 UTC by Petr Pisar
Modified: 2016-06-23 10:56 UTC (History)
2 users (show)

Fixed In Version: perl-RDF-Trine-1.014-1.fc25
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-01 08:34:22 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2016-03-24 14:23:10 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-RDF-Trine/perl-RDF-Trine.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-RDF-Trine/perl-RDF-Trine-1.014-1.fc25.src.rpm
Description:
RDF::Trine provides an Resource Descriptive Framework (RDF) with an
emphasis on extensibility, API stability, and the presence of a test suite.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-03-31 10:21:18 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

Binary requires are Ok.
Binary provides are Ok.

$ rpmlint ./perl-RDF-Trine* ./perl-Test-RDF-Trine-Store-1.014-1.fc25.noarch.rpm 
perl-RDF-Trine.noarch: W: spelling-error %description -l en_US extensibility -> sensibility, extensible
perl-RDF-Trine.noarch: W: spelling-error %description -l en_US mysql -> myself
perl-RDF-Trine.noarch: W: no-manual-page-for-binary srx2table
perl-RDF-Trine.noarch: W: no-manual-page-for-binary srx2csv
perl-RDF-Trine.src: W: spelling-error %description -l en_US extensibility -> sensibility, extensible
perl-RDF-Trine.src: W: spelling-error %description -l en_US mysql -> myself
8 packages and 1 specfiles checked; 0 errors, 6 warnings.
Rpmlint is ok

BuildRequires
FIX: Please update BRs
- add coreutils (spec file line 189)
- remove perl(Module::Install::AuthorTests) - author_tests is removed from Makefile.PL
- few BRs are listed twice
  - perl(Module::Load::Conditional)
  - perl(Test::Exception)
  - perl(Time::HiRes)

Please correct all 'FIX' issues.

Otherwise package looks good.
Approved.

Comment 2 Gwyn Ciesla 2016-04-01 01:53:38 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-RDF-Trine

Comment 3 Petr Pisar 2016-04-01 08:34:22 UTC
Thank you for the exhausting review and for the repository. I fixed all the reported mistakes.


Note You need to log in before you can comment on or make changes to this bug.