Bug 1321225 - the error info is not accurate when <boot order> is set as big number
Summary: the error info is not accurate when <boot order> is set as big number
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.2
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Peter Krempa
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-25 03:30 UTC by lijuan men
Modified: 2016-03-31 14:01 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-03-31 14:01:00 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description lijuan men 2016-03-25 03:30:03 UTC 
Description of problem:
the error info is not accurate when <boot order> is set as big number

Version-Release number of selected component (if applicable):
libvirt-1.3.2-1.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1.edit the guest xml as the following:
...
  <disk type='file' device='disk'>
      <driver name='qemu' type='qcow2'/>
      <source file='/var/lib/libvirt/images/aa.qcow2'/>
      <target dev='hda' bus='ide'/>
      <boot order='234000000000'/>       ---->set as a big number
      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
  </disk>
...

Actual results:
error: internal error: incorrect boot order '234000000000', expecting positive integer

Expected results:

'234000000000' is a positive integer,so the error info above is not so accurate

the error info could show the range of the 'boot order' value


Additional info:
Comment 2 Peter Krempa 2016-03-31 14:01:00 UTC 
While it's a correct observation I don't think it's worth fixing the error message. Boot order is usually a rather small value.
Note You need to log in before you can comment on or make changes to this bug.