Spec URL: https://daveisfera.fedorapeople.org/python-breathe_4.2.0/python-breathe.spec SRPM URL: https://daveisfera.fedorapeople.org/python-breathe_4.2.0/python-breathe-4.2.0-0.1.fc23.src.rpm Description: python-breathe is an extension to reStructuredText and Sphinx to be able to read and render the Doxygen xml output. Fedora Account System Username: daveisfera This is a re-review for a package rename of breathe (https://bugzilla.redhat.com/show_bug.cgi?id=1222227)
For the sake of documentation, this will take care of bug #1313796 and bug #1319391.
I though I had reviewed this already ;)
Yeah, the rename is reasonable. You don't need to define %sum. %summary refers to the previous Summary, you can just put the text in the first Summary, and then use Summary: %summary. The description for packages should contain the main part of the description too (the user only sees the binary packages). I'd suggest: %global _description \ Breathe is an extension to reStructuredText and Sphinx to be able to read and render the Doxygen xml output. %description %_description %description -n python2-breathe %_description %description -n python3-breathe %_description I don't know why you deleted the _docdir_fmt definition — it would still be useful. Provides/obsoletes look OK. Package is (RE-)APPROVED.
python-breathe-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-breathe-doc/html/.buildinfo → please remove.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > You don't need to define %sum. %summary refers to the previous Summary, you > can just put the text in the first Summary, and then use Summary: %summary. https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file I was just copying the example from the wiki. Does that need to be updated? > The description for packages should contain the main part of the description > too (the user only sees the binary packages). > > I'd suggest: > %global _description \ > Breathe is an extension to reStructuredText and Sphinx to be able to read and > render the Doxygen xml output. > > %description %_description > > %description -n python2-breathe %_description > > %description -n python3-breathe %_description Implemented. > I don't know why you deleted the _docdir_fmt definition — it would still be > useful. I wasn't sure why it was there and my googling indicated that I didn't need to set it ( https://fedoraproject.org/wiki/Changes/UnversionedDocdirs ). Should it be set? If so, should it be %{name} (python-breathe) or %{srcname} (breathe)? (In reply to Zbigniew Jędrzejewski-Szmek from comment #4) > python-breathe-doc.noarch: W: hidden-file-or-dir > /usr/share/doc/python-breathe-doc/html/.buildinfo > → please remove. Done. The updated files can be found at: Spec URL: https://daveisfera.fedorapeople.org/python-breathe_4.2.0/python-breathe.spec SRPM URL: https://daveisfera.fedorapeople.org/python-breathe_4.2.0/python-breathe-4.2.0-0.2.fc25.src.rpm
(In reply to Dave Johansen from comment #5) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > > You don't need to define %sum. %summary refers to the previous Summary, you > > can just put the text in the first Summary, and then use Summary: %summary. > > https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file > I was just copying the example from the wiki. Does that need to be updated? Possibly, but tibbs and others are working on creating a macro which would create whole python subpackages, so the change would be short-termed anyway. > > I don't know why you deleted the _docdir_fmt definition — it would still be > > useful. > I wasn't sure why it was there and my googling indicated that I didn't need > to set it ( https://fedoraproject.org/wiki/Changes/UnversionedDocdirs ). Instead of having /usr/share/doc/python-breathe-doc and /usr/share/licenses/python2-breathe/license and /usr/share/licenses/python3/license and /usr/share/licenses/python-breathe-doc/license you'd have /usr/share/doc/python-breathe and /usr/share/license/python-breathe, the latter coowned by all three subpackages. I think that's nicer for the user. > Should it be set? If so, should it be %{name} (python-breathe) or %{srcname} > (breathe)? %{name} is the standard. Current versions looks fine.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-breathe
python-breathe-4.2.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-1ffe139ba7
python-breathe-4.2.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c26ee51214
python-breathe-4.2.0-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9eabd21ea8
python-breathe-4.2.0-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9eabd21ea8
python-breathe-4.2.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-1ffe139ba7
python-breathe-4.2.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c26ee51214
Zbigniew - FYI - this package had a couple of missing python3 BR/Rs and the Requires: python-six needed to be in the python2-breathe package section.
Ack, thanks for catching that. Is there a reason to use %{python3_pkgversion}? By definition I don't think it can ever be anything other than 3?
It's an EPEL7 thing: https://fedoraproject.org/wiki/PackagingDrafts:Python3EPEL
python-breathe-4.2.0-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-39739947bd
python-breathe-4.2.0-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-45ebefd7af
python-breathe-4.2.0-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-c7b2eae53b
python-breathe-4.2.0-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-45ebefd7af
python-breathe-4.2.0-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d01d9f4466
python-breathe-4.2.0-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-39739947bd
python-breathe-4.2.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-c7b2eae53b
python-breathe-4.2.0-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d01d9f4466
python-breathe-4.2.0-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
python-breathe-4.2.0-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
python-breathe-4.2.0-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
python-breathe-4.2.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.