Bug 1321825 - Review Request: python-units - Python support for quantities with units
Summary: Review Request: python-units - Python support for quantities with units
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-29 08:46 UTC by Igor Gnatenko
Modified: 2016-04-19 20:31 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-19 20:31:04 UTC
Type: ---
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Igor Gnatenko 2016-03-29 08:46:12 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-units.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-units-0.06-1.fc25.src.rpm
Description:
Provides support for quantities and units, which strictly disallow invalid
operations between incompatible quantities. For example, we cannot add
2 metres to 5 seconds, because this doesn’t make sense.
Fedora Account System Username: ignatenkobrain

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-04-14 18:24:41 UTC
+ name is OK
+ license is OK (PSF)
+ license file is present, %license is used
+ python packaging macros are used
+ provides/requires look sane
+ %python_provide is used
+ no scriptlets present or necessary
+ builds and install OK

Package is APPROVED.

Comments:
I'd add:
%global _description \
Provides support for quantities and units, ...

%description %_description
%description -n python2-%{modname} %_description
%description -n python3-%{modname} %_description

I don't think deleting tests is proper. Quite often you want to run the tests on the target system.

Comment 2 Till Maas 2016-04-14 21:48:36 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-units

Comment 3 Fedora Update System 2016-04-15 05:37:13 UTC
python-units-0.06-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f0c42bf1c8

Comment 4 Fedora Update System 2016-04-15 23:22:16 UTC
python-units-0.06-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f0c42bf1c8

Comment 5 Fedora Update System 2016-04-19 20:31:00 UTC
python-units-0.06-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.