Bug 1322038 - ValueError: ovirt-node-ng-4.0.0-0.3.master.20160325135421.git02e2f29.el7 is not a valid name for this device
Summary: ValueError: ovirt-node-ng-4.0.0-0.3.master.20160325135421.git02e2f29.el7 is n...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-node
Classification: oVirt
Component: Installation & Update
Version: 4.0
Hardware: Unspecified
OS: Unspecified
unspecified
high vote
Target Milestone: ovirt-4.0.0-beta
: 4.0
Assignee: Fabian Deutsch
QA Contact: Wei Wang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-29 15:35 UTC by Douglas Schilling Landgraf
Modified: 2016-07-05 07:43 UTC (History)
3 users (show)

Fixed In Version: ovirt-node-ng-installer-master-20160406.iso
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-05 07:43:23 UTC
oVirt Team: Node
rule-engine: ovirt-4.0.0+
ycui: testing_plan_complete?
rule-engine: planning_ack+
rule-engine: devel_ack+
rule-engine: testing_ack+


Attachments (Terms of Use)
anaconda logs (87.75 KB, application/x-gzip)
2016-03-29 15:39 UTC, Douglas Schilling Landgraf
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 55432 0 master MERGED lvm: Validate LVM names 2020-06-24 12:56:57 UTC
oVirt gerrit 55439 0 master MERGED ks: Strip git-hash from image NVR 2020-06-24 12:56:57 UTC

Description Douglas Schilling Landgraf 2016-03-29 15:35:40 UTC
Description of problem:

Anaconda installation throw error message.

19:38:19,117 CRIT anaconda: Traceback (most recent call last):

  File "/usr/lib64/python2.7/site-packages/pyanaconda/threads.py", line 227, in run
    threading.Thread.run(self, *args, **kwargs)

  File "/usr/lib64/python2.7/threading.py", line 764, in run
    self.__target(*self.__args, **self.__kwargs)

  File "/usr/lib/python2.7/site-packages/blivet/__init__.py", line 184, in storageInitialize
    storage.reset()

  File "/usr/lib/python2.7/site-packages/blivet/__init__.py", line 489, in reset
    self.devicetree.populate(cleanupOnly=cleanupOnly)

  File "/usr/lib/python2.7/site-packages/blivet/devicetree.py", line 2228, in populate
    self._populate()

  File "/usr/lib/python2.7/site-packages/blivet/devicetree.py", line 2295, in _populate
    self.addUdevDevice(dev)

  File "/usr/lib/python2.7/site-packages/blivet/devicetree.py", line 1285, in addUdevDevice
    self.handleUdevDeviceFormat(info, device)

  File "/usr/lib/python2.7/site-packages/blivet/devicetree.py", line 1981, in handleUdevDeviceFormat
    self.handleUdevLVMPVFormat(info, device)

  File "/usr/lib/python2.7/site-packages/blivet/devicetree.py", line 1629, in handleUdevLVMPVFormat
    self.handleVgLvs(vg_device)

  File "/usr/lib/python2.7/site-packages/blivet/devicetree.py", line 1566, in handleVgLvs
    addLV(lv)

  File "/usr/lib/python2.7/site-packages/blivet/devicetree.py", line 1513, in addLV
    addRequiredLV(origin_device_name, "failed to locate origin lv")

  File "/usr/lib/python2.7/site-packages/blivet/devicetree.py", line 1426, in addRequiredLV
  File "/usr/lib/python2.7/site-packages/blivet/devicetree.py", line 1540, in addLV
    exists=True, **lv_kwargs)

  File "/usr/lib/python2.7/site-packages/blivet/devices/lvm.py", line 517, in __init__
    exists=exists)

  File "/usr/lib/python2.7/site-packages/blivet/devices/dm.py", line 73, in __init__
    parents=parents, sysfsPath=sysfsPath)

  File "/usr/lib/python2.7/site-packages/blivet/devices/storage.py", line 130, in __init__
    Device.__init__(self, name, parents=parents)

  File "/usr/lib/python2.7/site-packages/blivet/devices/device.py", line 84, in __init__
    raise ValueError("%s is not a valid name for this device" % name)

ValueError: ovirt-node-ng-4.0.0-0.3.master.20160325135421.git02e2f29.el7 is not a valid name for this device

19:38:19,121 DEBUG anaconda: Gtk running, queuing exception handler to the main loop
19:38:19,121 INFO anaconda: Thread Done: AnaPayloadThread (139908968818432)
19:38:19,919 DEBUG anaconda: network standalone spoke (init): completed: ['eth0']


Version-Release number of selected component (if applicable):
master branch in ovirt-node-ng tree

How reproducible:
make installed-squashfs
make debug-installed

The debug operation stuck, open the virtual machine via virt-manager and will see the message.

Comment 1 Douglas Schilling Landgraf 2016-03-29 15:39:42 UTC
Created attachment 1141326 [details]
anaconda logs

Comment 2 Fabian Deutsch 2016-03-29 15:58:45 UTC
We might be using a LVM name which is not suitable for blivet.

Comment 3 Douglas Schilling Landgraf 2016-03-30 04:41:38 UTC
(In reply to Fabian Deutsch from comment #2)
> We might be using a LVM name which is not suitable for blivet.

Others references with similar problem:

ValueError: /data is not a valid name for this device
https://bugzilla.redhat.com/show_bug.cgi?id=1219749

ValueError: cciss/c0d0 is not a valid name for this device
https://bugzilla.redhat.com/show_bug.cgi?id=1103751

Comment 4 Fabian Deutsch 2016-03-30 06:38:00 UTC
According to the blivet code, LVM devices should be at max 55 chars.

$ echo -n ovirt-node-ng-4.0.0-0.3.master.20160325135421.git02e2f29.el7 | wc -c
60

The name of the LV is to long.

Comment 5 Fabian Deutsch 2016-03-30 10:02:16 UTC
One patch no verifies the LVM name
The other patch reduces the default NVR of the image

Comment 6 Red Hat Bugzilla Rules Engine 2016-04-05 06:58:41 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 7 Fabian Deutsch 2016-04-06 20:46:20 UTC
Should be fixed in ovirt-node-ng-installer-master-20160406.iso

Comment 8 Wei Wang 2016-05-24 06:45:18 UTC
Test with the latest master branch in ovirt-node-ng, the bug cannot reproduced.

Steps:
1. dnf install lorax libvirt libvirt-daemon-kvm virt-install libguestfs-tools
2. git clone git://gerrit.ovirt.org/ovirt-node-ng.git
3. ./autogen.sh
4. make squashfs
5. make installed-squashfs
6. make debug-installed

Result:
Install successfully.

The bug is verified, so I change the status to VERIFIED.

Comment 9 Sandro Bonazzola 2016-07-05 07:43:23 UTC
oVirt 4.0.0 has been released, closing current release.


Note You need to log in before you can comment on or make changes to this bug.