Bug 1323698 - [RFE] update bootstrap, gwtbootstrap3, and patternfly to latest versions
Summary: [RFE] update bootstrap, gwtbootstrap3, and patternfly to latest versions
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.Core
Version: 4.0.0
Hardware: All
OS: Unspecified
medium
medium vote
Target Milestone: ovirt-4.2.0
: 4.2.0
Assignee: Greg Sheremeta
QA Contact: Pavel Novotny
URL:
Whiteboard:
Depends On:
Blocks: 1370125
TreeView+ depends on / blocked
 
Reported: 2016-04-04 13:04 UTC by Greg Sheremeta
Modified: 2019-04-28 14:23 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-20 10:43:20 UTC
oVirt Team: UX
oourfali: ovirt-4.2?
gklein: testing_plan_complete-
rule-engine: planning_ack?
gshereme: devel_ack+
lsvaty: testing_ack+

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 61716 0 None None None 2017-01-04 23:48:47 UTC

Description Greg Sheremeta 2016-04-04 13:04:26 UTC 
Description of problem:
update bootstrap, gwtbootstrap3, and patternfly to latest versions

in particular, make sure we consume bootstrap >= 3.3.7 and remove our custom copy of bootstrap.

Version-Release number of selected component (if applicable):
4.0
Comment 1 Red Hat Bugzilla Rules Engine 2016-04-04 13:05:30 UTC 
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.
Comment 2 Yaniv Kaul 2016-04-04 13:58:23 UTC 
3.3.7 is supposed to have a fix for https://github.com/twbs/bootstrap/issues/17973 : Tooltip causing memory leak
PR - https://github.com/twbs/bootstrap/pull/19659
Comment 3 Sandro Bonazzola 2016-05-02 09:48:44 UTC 
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.
Comment 4 Yaniv Lavi 2016-05-23 13:13:31 UTC 
oVirt 4.0 beta has been released, moving to RC milestone.
Comment 5 Oved Ourfali 2016-05-25 13:47:05 UTC 
iirc we said we will do that for 4.1, right?
Is there a bootstrap version with the leak fix?
Comment 6 Greg Sheremeta 2016-05-25 16:33:59 UTC 
> iirc we said we will do that for 4.1, right?
Yes.

> Is there a bootstrap version with the leak fix?
Not yet. 3.3.7 and 4.0.0 will have it -- neither has been released.
Comment 7 Vojtech Szocs 2016-05-30 16:01:50 UTC 
Does this also mean we'll get rid of the ancient jQuery 1.x?

Given that we already have oVirt JavaScript dependencies packaged via RPM (ovirt-engine-nodejs-modules), I'd prefer to make Engine depend on this RPM and symlink to them from within branding directory, if possible.
Comment 8 Greg Sheremeta 2016-05-31 16:27:51 UTC 
> Does this also mean we'll get rid of the ancient jQuery 1.x?

Yes. We'll just depend on ovirt-engine-nodejs-modules now.
Comment 9 Greg Sheremeta 2017-03-02 14:07:34 UTC 
(In reply to Greg Sheremeta from comment #8)
> > Does this also mean we'll get rid of the ancient jQuery 1.x?
> 
> Yes. We'll just depend on ovirt-engine-nodejs-modules now.

Correction -- we depend on ovirt-js-dependencies.
Comment 11 Pavel Novotny 2017-09-04 15:20:53 UTC 
Verified in ovirt-engine-webadmin-portal-4.2.0-0.0.master.20170903205106.gitb17261a.el7.centos.noarch

Web UI sanity tests haven't found any regression.
Comment 12 Sandro Bonazzola 2017-12-20 10:43:20 UTC 
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Note You need to log in before you can comment on or make changes to this bug.