Hide Forgot
Description of problem: Currently there is no way to debug a failed rsync command from oc, A debug option for rsync command, should be allowed. In short the following should be updated, to add 'verbose' as an option https://github.com/openshift/origin/blob/master/pkg/cmd/cli/cmd/rsync/rsync.go#L101-L114 https://github.com/openshift/origin/blob/master/pkg/cmd/cli/cmd/rsync/copyrsync.go#L38-L44 The following also likely needs to be updated. https://github.com/openshift/origin/blob/master/pkg/cmd/cli/cmd/rsync/copyrsync.go#L31
Ryan is implementing this RFE this sprint.
From the code, it looks like is --verbose is already set if --quiet is not set (rsync/util.go:86), and the command automatically gives all the debug information that rsync and tar report. What information are you looking for? We could print more information from the Openshift side. Could you give me an example? Thank you!
(In reply to Ryan Murphy from comment #3) > From the code, it looks like is --verbose is already set if --quiet is not > set (rsync/util.go:86), and the command automatically gives all the debug > information that rsync and tar report. What information are you looking > for? We could print more information from the Openshift side. Could you > give me an example? > > Thank you! In the links I provided I don't see where verbose is set or enabled? https://github.com/openshift/origin/blob/master/pkg/cmd/cli/cmd/rsync/rsync.go#L101-L114 https://github.com/openshift/origin/blob/master/pkg/cmd/cli/cmd/rsync/copyrsync.go#L38-L44 The following is example output where quite is false (the default), and there are no verbose messages, that one could use for troubleshooting an rsync error with this command. > oc rsync hawkular-metrics-m4pdv:.m2/settings.xml . >receiving incremental file list >settings.xml > >sent 30 bytes received 5816 bytes 11692.00 bytes/sec >total size is 5729 speedup is 0.98
Hello Here is where verbose is set for Rsync https://github.com/openshift/origin/blob/master/pkg/cmd/cli/cmd/rsync/util.go#L81-L104 As long as --quiet isn't used, -v is set for rsync. I'm not sure how your example is failing, it looks like it succeeds? What information are you expecting? Thank you!
(In reply to Ryan Murphy from comment #5) > Hello > > Here is where verbose is set for Rsync > https://github.com/openshift/origin/blob/master/pkg/cmd/cli/cmd/rsync/util. > go#L81-L104 > > As long as --quiet isn't used, -v is set for rsync. > > I'm not sure how your example is failing, it looks like it succeeds? What > information are you expecting? > > Thank you! The example used was when a transfer is good, however if the transfer is bad, its (which its not clear from the output I provided) that debug information is supplied. We can close this, given that the setting are already set.